Remove DemuxerFactory and URL parameter from Pipeline.

media/base/demuxer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DEMUXER_H_
 #define MEDIA_BASE_DEMUXER_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/time.h"
 #include "media/base/data_source.h"
@@ skipping 21 matching lines @@
   // Stops execution of the pipeline due to a fatal error.  Do not call this
   // method with PIPELINE_OK.
   virtual void OnDemuxerError(PipelineStatus error) = 0;
 };
 
 class MEDIA_EXPORT Demuxer
     : public base::RefCountedThreadSafe<Demuxer> {
  public:
   Demuxer();
 
+  // Completes initialization of the demuxer.
+  virtual void Initialize(const PipelineStatusCB& status_cb) = 0;

[acolwell GONE FROM CHROMIUM, 2012/03/27 20:11:35]

How about removing set_host() and adding DemuxerHost as a parameter to
Initialize()?

[scherkus (not reviewing), 2012/03/27 20:44:09]

added a TODO w/ bug as I was planning on doing that in a follow-up CL

it involves updating a bunch of tests :\

+
   // Sets the private member |host_|. This is the first method called by
   // the DemuxerHost after a demuxer is created.  The host holds a strong
   // reference to the demuxer.  The reference held by the host is guaranteed
   // to be released before the host object is destroyed by the pipeline.
   virtual void set_host(DemuxerHost* host);
 
   // The pipeline playback rate has been changed.  Demuxers may implement this
   // method if they need to respond to this call.
   virtual void SetPlaybackRate(float playback_rate);
 
@@ skipping 17 matching lines @@
 
   // Returns the starting time for the media file.
   virtual base::TimeDelta GetStartTime() const = 0;
 
   // Returns the content bitrate. May be obtained from container or
   // approximated. Returns 0 if it is unknown.
   virtual int GetBitrate() = 0;
 
   // Returns true if the source is from a local file or stream (such as a
   // webcam stream), false otherwise.
+  //
+  // TODO(scherkus): See http://crbug.com/120426 on why we should remove this.
   virtual bool IsLocalSource() = 0;
 
   // Returns true if seeking is possible; false otherwise.
   virtual bool IsSeekable() = 0;
 
  protected:
   // Only allow derived objects access to the DemuxerHost. This is
   // kept out of the public interface because demuxers need to be
   // aware of all calls made to the host object so they can insure
   // the state presented to the host is always consistent with its own
   // state.
   DemuxerHost* host() { return host_; }
 
   friend class base::RefCountedThreadSafe<Demuxer>;
   virtual ~Demuxer();
 
  private:
   DemuxerHost* host_;
 
   DISALLOW_COPY_AND_ASSIGN(Demuxer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DEMUXER_H_