Issue 9860018: DomStorageContext unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9860018: DomStorageContext unittests (Closed)

Created:
8 years, 9 months ago by michaeln

Modified:
8 years, 9 months ago

Reviewers:
jsbell

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

DomStorageContext unittests. TBR=tony BUG=106763 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129317

Patch Set 5 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -0 lines)			Patch
M	webkit/dom_storage/dom_storage_context.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	webkit/dom_storage/dom_storage_context_unittest.cc	View	1 2 3 4	1 chunk	+181 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jsbell

lgtm http://codereview.chromium.org/9860018/diff/3003/webkit/dom_storage/dom_storage_context_unittest.cc File webkit/dom_storage/dom_storage_context_unittest.cc (right): http://codereview.chromium.org/9860018/diff/3003/webkit/dom_storage/dom_storage_context_unittest.cc#newcode93 webkit/dom_storage/dom_storage_context_unittest.cc:93: const bool kIncludeFileInfo = true; Maybe rename to ...

8 years, 9 months ago (2012-03-27 18:22:03 UTC) #2

michaeln

8 years, 9 months ago (2012-03-27 22:32:09 UTC) #3

http://codereview.chromium.org/9860018/diff/3003/webkit/dom_storage/dom_stora...
File webkit/dom_storage/dom_storage_context_unittest.cc (right):

http://codereview.chromium.org/9860018/diff/3003/webkit/dom_storage/dom_stora...
webkit/dom_storage/dom_storage_context_unittest.cc:93: const bool
kIncludeFileInfo = true;
On 2012/03/27 18:22:03, jsbell wrote:
> Maybe rename to kDoIncludeFileInfo since kIncludeFileInfo = false is used in
> previous test.

Done, I made these const data members of the test fixture base class.

Expand Messages | Collapse Messages

Issue 9860018: DomStorageContext unittests (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages