Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 9857017: Revert 128889 - Update IME preferences outside the IME status button when Uber Tray is in use. (Closed)

Created:
8 years, 9 months ago by nduca
Modified:
8 years, 9 months ago
Reviewers:
Yusuke (unused)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Revert 128889 - Update IME preferences outside the IME status button when Uber Tray is in use. * browser_state_monitor.cc/h: Added. The class which monitors a notification from the browser to keep track of the browser state (not logged in, logged in, etc.) and notify the current state to the input method manager. The class also updates the appropriate Chrome prefs (~/Local\ State or ~/Preferences) depending on the current browser state. When Uber Tray is disabled via chrome://flags, the class does nothing. In the next CL, I'll remove all preference code from InputMethodButton and make browser_state_monitor.cc work regardless of whether Uber Tray is disabled or not. * preferences.cc: When Uber Tray is enabled, handle prefs::kLanguageCurrentInputMethod and prefs::kLanguagePreviousInputMethod prefs in the class. preferences.cc is the standard place for checking the initial values of Chrome OS specific user prefs. BUG=chromiun-os:28297 TEST=manual (not ready for writing unit tests. It will be done as part of 19655 very soon for R20). Checked test cases in http://code.google.com/p/chromium-os/issues/detail?id=19655#c11. Review URL: https://chromiumcodereview.appspot.com/9852008 TBR=yusukes@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -324 lines) Patch
D chrome/browser/chromeos/input_method/browser_state_monitor.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/chromeos/input_method/browser_state_monitor.cc View 1 chunk +0 lines, -203 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 3 chunks +1 line, -26 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
nduca
8 years, 9 months ago (2012-03-26 16:37:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698