Update IME preferences outside the IME status button when Uber Tray is in use.

Update IME preferences outside the IME status button when Uber Tray is in use.

* browser_state_monitor.cc/h:

Added. The class which monitors a notification from the browser to keep track of the browser state (not logged in, logged in, etc.) and notify the current state to the input method manager. The class also updates the appropriate Chrome prefs (~/Local\ State or ~/Preferences) depending on the current browser state.

When Uber Tray is disabled via chrome://flags, the class does nothing. In the next CL, I'll remove all preference code from InputMethodButton and make browser_state_monitor.cc work regardless of whether Uber Tray is disabled or not.

* preferences.cc:

When Uber Tray is enabled, handle prefs::kLanguageCurrentInputMethod and prefs::kLanguagePreviousInputMethod prefs in the class.  preferences.cc is the standard place for checking the initial values of Chrome OS specific user prefs.

BUG=chromiun-os:28297
BUG=120198
TEST=manual (not ready for writing unit tests. It will be done as part of 19655 very soon for R20). Checked test cases in http://code.google.com/p/chromium-os/issues/detail?id=19655#c11.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128889

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129154

[Yusuke Sato, 2012-03-26 06:02:36]

Zach, could you review this? This is for a P1 M19 issue.

I implemented browser_state_monitor.h/cc originally for the IME refactoring task
for M20 (crosbug.com/19655), but I'd like to merge it to M19 to support Uber
Tray version of Chrome OS.

[Zachary Kuznia, 2012-03-26 06:26:07]

http://codereview.chromium.org/9852008/diff/6004/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/browser_state_monitor.cc (right):

http://codereview.chromium.org/9852008/diff/6004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/browser_state_monitor.cc:102:
UpdateLocalState(current_input_method.id());
Does this handle the case where an IME is being used because the user is
creating a new account?

[Yusuke Sato, 2012-03-26 06:42:43]

http://codereview.chromium.org/9852008/diff/6004/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/browser_state_monitor.cc (right):

http://codereview.chromium.org/9852008/diff/6004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/browser_state_monitor.cc:102:
UpdateLocalState(current_input_method.id());
Actually Aura version of Chrome OS never enables an IME on the login screen.
When the user clicks "Create a new Google Account now" link, the user is
directed to the Guest login mode which is outside the login screen. So only an
XKB ID should be written to the Local\ State file.

On 2012/03/26 06:26:07, Zachary Kuznia wrote:
> Does this handle the case where an IME is being used because the user is
> creating a new account?

[Zachary Kuznia, 2012-03-26 06:45:54]

lgtm

[commit-bot: I haz the power, 2012-03-26 06:56:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9852008/6004

[commit-bot: I haz the power, 2012-03-26 09:56:33]

Try job failure for 9852008-6004 (retry) (retry) on win_rel for step
"browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Yusuke Sato, 2012-03-27 01:51:53]

Zach, I slightly changed the wat to delete browser_state_monitor_  to fix
crbug.com/120198. Could you take another look at
chrome/browser/chromeos/input_method/input_method_manager.cc (patch set 2)?


On 2012/03/26 09:56:33, I haz the power (commit-bot) wrote:
> Try job failure for 9852008-6004 (retry) (retry) on win_rel for step
> "browser_tests" (clobber build).
> It's a second try, previously, step "compile" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Zachary Kuznia, 2012-03-27 01:54:34]

lgtm

[Yusuke Sato, 2012-03-27 02:55:36]

git try -b cros_x86 passed. re-landing..

[commit-bot: I haz the power, 2012-03-27 02:55:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9852008/12001

[commit-bot: I haz the power, 2012-03-27 06:33:49]

Change committed as 129154