Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 985613002: ScopedCrashKey doesn't appear to be configured to work on Windows. Manually set the crash key. (Closed)

Created:
5 years, 9 months ago by erikwright (departed)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, Sigurður Ásgeirsson, Sébastien Marchand, Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/src.git@kasko_0_0_7_0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScopedCrashKey doesn't appear to be configured to work on Windows. Manually set the crash key. BUG=460512 TBR=grt Committed: https://crrev.com/af3e767a66b82c6f8510db2fb8eeeb0d2f89409c Cr-Commit-Position: refs/heads/master@{#319411}

Patch Set 1 #

Patch Set 2 : Fix headers. #

Patch Set 3 : Fix namespace/headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/app/kasko_client.cc View 1 2 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
erikwright (departed)
I'll need to follow up with rsesek to understand, but base::debug::SetCrashKeyReportingFunctions never seems to be ...
5 years, 9 months ago (2015-03-06 03:44:08 UTC) #2
erikwright (departed)
+cpu, rsesek I've verified that with this patch the kasko crash key is actually included ...
5 years, 9 months ago (2015-03-06 03:49:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985613002/40001
5 years, 9 months ago (2015-03-06 03:50:28 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-06 04:33:21 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/af3e767a66b82c6f8510db2fb8eeeb0d2f89409c Cr-Commit-Position: refs/heads/master@{#319411}
5 years, 9 months ago (2015-03-06 04:34:05 UTC) #8
Robert Sesek
5 years, 9 months ago (2015-03-06 16:53:51 UTC) #10
Message was sent while issue was closed.
As I wrote over email, I don't think this is the right approach. You should set
the reporting functions instead, and then crash_logging.h should work:
https://code.google.com/p/chromium/codesearch#chromium/src/base/debug/crash_l...

Powered by Google App Engine
This is Rietveld 408576698