Normalize download file name on chromeos

base/i18n/file_util_icu.h

Index: base/i18n/file_util_icu.h
diff --git a/base/i18n/file_util_icu.h b/base/i18n/file_util_icu.h
index 57acea64de8a99e314247ae2d2c12335dfd22bfd..6e388758e62299bf6d46723bbea20102899226a7 100644
--- a/base/i18n/file_util_icu.h
+++ b/base/i18n/file_util_icu.h
@@ -35,6 +35,9 @@ BASE_I18N_EXPORT void ReplaceIllegalCharactersInPath(
 BASE_I18N_EXPORT bool LocaleAwareCompareFilenames(const FilePath& a,
                                                   const FilePath& b);
 
+// If running on ChromeOS, normalizes file name.

[asanka, 2012/03/26 22:08:35]

// Calculates the canonical file-system representation of |file_name|. Modifies
|file_name| in-place.

The impression I get is that this should only modify the
|file_name->BaseName()|. If so, that should be documented and the implementation
should follow suit.

Given that there's a file_util::NormalizeFilePath(), you might consider calling
this NormalizeFilenameEncoding() or something similar. Let it be a no-op for now
on non-ChromeOS platforms.

[tbarzic, 2012/03/26 22:57:26]

Done.

+BASE_I18N_EXPORT void NormalizeFileNameOnChromeOS(FilePath* file_name);
+
 }  // namespace file_util
 
 #endif  // BASE_I18N_FILE_UTIL_ICU_H_