Normalize download file name on chromeos

base/i18n/file_util_icu.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_I18N_FILE_UTIL_ICU_H_
 #define BASE_I18N_FILE_UTIL_ICU_H_
 #pragma once
 
 // File utilities that use the ICU library go in this file.
 
@@ skipping 17 matching lines @@
 BASE_I18N_EXPORT void ReplaceIllegalCharactersInPath(
     FilePath::StringType* file_name,
     char replace_char);
 
 // Compares two filenames using the current locale information. This can be
 // used to sort directory listings. It behaves like "operator<" for use in
 // std::sort.
 BASE_I18N_EXPORT bool LocaleAwareCompareFilenames(const FilePath& a,
                                                   const FilePath& b);
 
+// If running on ChromeOS, normalizes file name.

[asanka, 2012/03/26 22:08:35]

// Calculates the canonical file-system representation of |file_name|. Modifies
|file_name| in-place.

The impression I get is that this should only modify the
|file_name->BaseName()|. If so, that should be documented and the implementation
should follow suit.

Given that there's a file_util::NormalizeFilePath(), you might consider calling
this NormalizeFilenameEncoding() or something similar. Let it be a no-op for now
on non-ChromeOS platforms.

[tbarzic, 2012/03/26 22:57:26]

Done.

+BASE_I18N_EXPORT void NormalizeFileNameOnChromeOS(FilePath* file_name);
+
 }  // namespace file_util
 
 #endif  // BASE_I18N_FILE_UTIL_ICU_H_