Issue 9854009: Add tooltip text for chrome shortcut

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9854009: Add tooltip text for chrome shortcut (Closed)

Created:
8 years, 9 months ago by DaveMoore

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add tooltip text for chrome shortcut Also, make ctrl-click on chrome shortcut open new tab in new window. BUG=119969 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128843

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Add method to ash_shell #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -11 lines)			Patch
M	ash/ash_strings.grd	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/launcher/launcher_delegate.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ash/launcher/launcher_view.cc	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	ash/shell/launcher_delegate_impl.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/shell/launcher_delegate_impl.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc	View		1 chunk	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

There's another LauncherDelegate in tests you'll need to update too. LGTM otherwise

8 years, 9 months ago (2012-03-25 23:07:06 UTC) #2

sky

8 years, 9 months ago (2012-03-25 23:08:50 UTC) #3

It's shell/launcher_delegate_impl

On Sun, Mar 25, 2012 at 4:07 PM,  <sky@chromium.org> wrote:
> There's another LauncherDelegate in tests you'll need to update too. LGTM
> otherwise
>
> https://chromiumcodereview.appspot.com/9854009/

Expand Messages | Collapse Messages