Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 9853033: Enable some sandboxed translation tests (Closed)

Created:
8 years, 9 months ago by Derek Schuff
Modified:
8 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Enable some sandboxed translation tests Except do it right this time. Summary: Use the standalone sandboxed translator driver for all arches in sbtc mode. Don't stub-out the translate command; actually translate. Adjust buildbot scripts to run the right tests, and don't build the prerequisites on arm hw BUG= http://code.google.com/p/nativeclient/issues/detail?id=2407 TEST= arm bots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8114

Patch Set 1 #

Patch Set 2 : don't do non-translator tests with generate_pexe #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M SConstruct View 1 chunk +2 lines, -1 line 0 comments Download
M buildbot/buildbot_pnacl.sh View 1 4 chunks +9 lines, -5 lines 2 comments Download
M site_scons/site_tools/naclsdk.py View 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
Except do it right this time. Summary: Use the standalone sandboxed translator driver for all ...
8 years, 9 months ago (2012-03-26 23:03:30 UTC) #1
jvoung - send to chromium...
otherwise lgtm https://chromiumcodereview.appspot.com/9853033/diff/3001/buildbot/buildbot_pnacl.sh File buildbot/buildbot_pnacl.sh (right): https://chromiumcodereview.appspot.com/9853033/diff/3001/buildbot/buildbot_pnacl.sh#newcode293 buildbot/buildbot_pnacl.sh:293: scons-tests-translator "arm" "--mode=opt-host,nacl -j4 -k" "toolchain_tests" Should ...
8 years, 9 months ago (2012-03-26 23:21:14 UTC) #2
Derek Schuff
8 years, 9 months ago (2012-03-26 23:30:19 UTC) #3
https://chromiumcodereview.appspot.com/9853033/diff/3001/buildbot/buildbot_pn...
File buildbot/buildbot_pnacl.sh (right):

https://chromiumcodereview.appspot.com/9853033/diff/3001/buildbot/buildbot_pn...
buildbot/buildbot_pnacl.sh:293: scons-tests-translator "arm"
"--mode=opt-host,nacl -j4 -k" "toolchain_tests"
Yeah i guess so. this is the bot i'm about to refactor away, but might as well
have it work for now ;)
On 2012/03/26 23:21:15, jvoung wrote:
> Should this build pre-reqs first too?

Powered by Google App Engine
This is Rietveld 408576698