Issue 9853022: gdata: Fix a bug that caused a deadlock when "Google Docs" is clicked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9853022: gdata: Fix a bug that caused a deadlock when "Google Docs" is clicked (Closed)

Created:
8 years, 9 months ago by satorux1

Modified:
8 years, 9 months ago

Reviewers:
Jun Mukai, Ben Chan

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Fix a bug that caused a deadlock when "Google Docs" is clicked Regressed in crrev.com/128867. Sorry about this! BUG=chromium-os:28416 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128919

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		1 chunk	+9 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Chan

8 years, 9 months ago (2012-03-26 16:28:41 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9853022/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/9853022/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/gdata/gdata_file_system.cc:530:
base::MessageLoopProxy::current()->PostTask(
Let's look into a better way to handle the lock business... preferably no lock
once after we clean up the thread interactions.

Expand Messages | Collapse Messages