gdata: Fix a bug that caused a deadlock when "Google Docs" is clicked

chrome/browser/chromeos/gdata/gdata_file_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_file_system.h"
 
 #include <errno.h>
 
 #include <utility>
 
@@ skipping 506 matching lines @@
     LoadRootFeedFromCache(search_file_path,
                           true,     // should_load_from_server
                           callback);
     return;
   } else if (root_->NeedsRefresh()) {
     // If content is stale or from disk from cache, fetch content from
     // the server.
     LoadFeedFromServer(search_file_path, callback);
     return;
   }
-  GDataFileSystem::FindFileByPathOnCallingThread(
-      search_file_path,
-      callback);
+
+  // Post a task to the same thread, rather than calling it here, as
+  // FindFileByPathAsync() is asynchronous.
+  base::MessageLoopProxy::current()->PostTask(

[Ben Chan, 2012/03/26 16:28:42]

Let's look into a better way to handle the lock business... preferably no lock
once after we clean up the thread interactions.

+      FROM_HERE,
+      base::Bind(&GDataFileSystem::FindFileByPathOnCallingThread,
+                 GetWeakPtrForCurrentThread(),
+                 search_file_path,
+                 callback));
 }
 
 void GDataFileSystem::FindFileByPathOnCallingThread(
     const FilePath& search_file_path,
     const FindFileCallback& callback) {
   FindFileCallbackRelayDelegate delegate(callback);
   FindFileByPathSync(search_file_path, &delegate);
 }
 
 void GDataFileSystem::LoadFeedFromServer(
@@ skipping 3022 matching lines @@
   const bool posted = BrowserThread::PostTask(
       BrowserThread::FILE,
       from_here,
       base::Bind(&GDataFileSystem::RunTaskOnIOThreadPool,
                  base::Unretained(this),
                  task));
   DCHECK(posted);
 }
 
 }  // namespace gdata