Changed recipe_modules base paths to be abstract entities in their own right.

Changed recipe_modules base paths to be abstract entities in their own right.

So rather than [BUILD]/scripts/slave/recipe_modules/path/resources, we see
RECIPE_MODULE[path]/resources.

This is necessary to allow recipe modules to live outside of build and
build_internal.

CL Organization:

Patchset 1: Manually substituted expectations the way I expected this change to work:

$ find -wholename '*.expected/*.json' -print0 | xargs -0 perl -pi -e 's#\[BUILD\]/scripts/slave/recipe_modules/(\w+)#MODULE\[\1\]#'
$ find -wholename '*.expected/*.json' -print0 | xargs -0 perl -pi -e 's#\[BUILD\]\\\\scripts\\\\slave\\\\recipe_modules\\\\(\w+)#MODULE\[\1\]#'

Patchset 2: The actual code change.  Simulation tests were done to verify the change, but not trained.  

NOPRESUBMIT because of pylint changes. We gotta fix this.

BUG=459840
NOPRESUBMIT=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294385

[luqui, 2015-03-07 02:29:54]

luqui@chromium.org changed reviewers:
+ iannucci@chromium.org

[luqui, 2015-03-07 02:29:57]

ptal.  Simpler than it looks.

[luqui, 2015-03-07 02:48:04]

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/path/api.py (right):

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/path/api.py:25: base_path = repr(path.base)
See if you (I) can make this a normal method instead of repr()

[iannucci, 2015-03-07 02:55:03]

lgtm % comments

Thank you for doing this!

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
File scripts/slave/recipe_config_types.py (right):

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
scripts/slave/recipe_config_types.py:86: class ModuleBasePath(BasePath,
namedtuple('ModuleBasePath', ('module',))):
I think this r an oops. Let's stick with line 70 style

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
scripts/slave/recipe_config_types.py:88: name = re.sub(r'^RECIPE_MODULES\.', '',
self.module.__name__)
let's pull the regex out too, and add a comment as appropriate (similar to the
other one)

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
scripts/slave/recipe_config_types.py:89: return 'MODULE[%s]' % name
let's do "RECIPE_MODULE" instead, since MODULE is overloaded (esp if you see
MODULE[os], etc)

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
File scripts/slave/recipe_modules/path/api.py (right):

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
scripts/slave/recipe_modules/path/api.py:14: def PathTostring(api, test):
Can you fix the capitalization here? kthx :D

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
File scripts/slave/recipe_modules/path/config.py (right):

https://chromiumcodereview.appspot.com/985273002/diff/20001/scripts/slave/rec...
scripts/slave/recipe_modules/path/config.py:6: from slave.recipe_config_types
import Path, NamedBasePath
unused?

[iannucci, 2015-03-07 02:56:11]

This is how I feel about this patch: http://i.imgur.com/B56ghzt.gif

[luqui, 2015-03-09 18:49:28]

landing...

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_con...
File scripts/slave/recipe_config_types.py (right):

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_con...
scripts/slave/recipe_config_types.py:86: class ModuleBasePath(BasePath,
namedtuple('ModuleBasePath', ('module',))):
On 2015/03/07 02:55:02, iannucci wrote:
> I think this r an oops. Let's stick with line 70 style

Done.

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_con...
scripts/slave/recipe_config_types.py:88: name = re.sub(r'^RECIPE_MODULES\.', '',
self.module.__name__)
On 2015/03/07 02:55:03, iannucci wrote:
> let's pull the regex out too, and add a comment as appropriate (similar to the
> other one)

Done.

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_con...
scripts/slave/recipe_config_types.py:89: return 'MODULE[%s]' % name
On 2015/03/07 02:55:02, iannucci wrote:
> let's do "RECIPE_MODULE" instead, since MODULE is overloaded (esp if you see
> MODULE[os], etc)

Done.

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/path/api.py (right):

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/path/api.py:14: def PathTostring(api, test):
On 2015/03/07 02:55:03, iannucci wrote:
> Can you fix the capitalization here? kthx :D

Done.

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/path/api.py:25: base_path = repr(path.base)
On 2015/03/07 02:48:04, luqui wrote:
> See if you (I) can make this a normal method instead of repr()

Changed my mind about this...

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/path/config.py (right):

https://codereview.chromium.org/985273002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/path/config.py:6: from slave.recipe_config_types
import Path, NamedBasePath
On 2015/03/07 02:55:03, iannucci wrote:
> unused?

Done.

[luqui, 2015-03-09 18:49:45]

The CQ bit was checked by luqui@chromium.org

[luqui, 2015-03-09 18:49:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/985273002/#ps80001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-03-09 18:50:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985273002/80001

[commit-bot: I haz the power, 2015-03-09 19:00:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 19:00:45]

Presubmit check for 985273002-80001 failed and returned exit status 1.

Running presubmit commit checks ...
  checking eol style took a long time: 985ms

** Presubmit ERRORS **
Pylint (574 files) (301.42s) failed
No config file found, using default configuration
************* Module PRESUBMIT
I:110, 0: Locally disabling import-error (F0401) (locally-disabled)
W: 15, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 16, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W: 18, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 32, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 34, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 36, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 37, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 38, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W: 49, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
C: 50, 0: Wrong hanging indentation.
      'C0301',  # Line too long (NN/80)
      ^ | (bad-continuation)
C: 51, 0: Wrong hanging indentation.
      'C0321',  # More than one statement on a single line
      ^ | (bad-continuation)
C: 52, 0: Wrong hanging indentation.
      'W0613',  # Unused argument
      ^ | (bad-continuation)
W: 54, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W: 59, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 60, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W: 65, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 68, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 69, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 70, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 73, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 78, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 83, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 88, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 93, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 99, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:101, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:102, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:108, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:109, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:110, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:112, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:113, 0: Bad indentation. Found 6 spaces, expected 12 (bad-indentation)
W:115, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
C:116, 0: Wrong hanging indentation.
      input_api, output_api, excluded_paths=black_list))
      ^ | (bad-continuation)
W:117, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:118, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:119, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:123, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:127, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:128, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:131, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:133, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:134, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:135, 0: Bad indentation. Found 6 spaces, expected 12 (bad-indentation)
W:136, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:141, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:142, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:144, 0: Bad indentation. Found 4 spaces, expected 8 (bad-indentation)
W:145, 0: Bad indentation. Found 6 spaces, expected 12 (bad-indentation)
W:148, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:152, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:153, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:154, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:158, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:159, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:160, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:161, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C: 14, 0: Invalid function name "CommonChecks" (invalid-name)
C: 14, 0: Missing function docstring (missing-docstring)
C: 15, 2: Missing function docstring (missing-docstring)
C:122, 0: Invalid function name "ConditionalChecks" (invalid-name)
C:140, 0: Invalid function name "BuildInternalCheck" (invalid-name)
C:140, 0: Missing function docstring (missing-docstring)
C:151, 0: Invalid function name "CheckChangeOnUpload" (invalid-name)
C:151, 0: Missing function docstring (missing-docstring)
C:157, 0: Invalid function name "CheckChangeOnCommit" (invalid-name)
C:157, 0: Missing function docstring (missing-docstring)
************* Module environment.cfg
W: 12, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 16, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 17, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 24, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 43, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C: 11, 0: Invalid function name "Extend" (invalid-name)
W: 24,17: Used * or ** magic (star-args)
W: 43, 9: Used * or ** magic (star-args)
************* Module master_site_config
W: 10, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 11, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 12, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 13, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 14, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C:  9, 0: Missing class docstring (missing-docstring)
R:  9, 0: Too few public methods (0/2) (too-few-public-methods)
W: 10, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 11, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 12, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 13, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 14, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C:  9, 0: Missing class docstring (missing-docstring)
R:  9, 0: Too few public methods (0/2) (too-few-public-methods)
************* Module master_chromiumos_cfg
W: 13, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C: 18, 0: Wrong hanging indentation.
          'Linux ChromiumOS Full',
          ^                     | (bad-continuation)
C: 19, 0: Wrong hanging indentation.
          'Linux ChromiumOS Builder',
          ^                     | (bad-continuation)
C: 20, 0: Wrong hanging indentation.
          'Linux ChromiumOS Ozone Builder',
          ^                     | (bad-continuation)
C: 21, 0: Wrong hanging indentation.
          'Linux ChromiumOS Builder (dbg)',
          ^                     | (bad-continuation)
C: 22, 0: Wrong hanging indentation.
          'Linux ChromiumOS GN',
          ^                     | (bad-continuation)
C: 23, 0: Wrong hanging indentation.
      ]),
      ^                     |   | (bad-continuation)
W: 34, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C: 36, 0: Wrong hanging indentation.
        'name': spec['buildername'],
        ^ | (bad-continuation)
C: 37, 0: Wrong hanging indentation.
        'factory': m_annotator.BaseFactory('chromium',
        ^ | (bad-continuation)
C: 39, 0: Wrong hanging indentation.
        'notify_on_missing': True,
        ^ | (bad-continuation)
C: 40, 0: Wrong hanging indentation.
        'category': '1linux',
        ^ | (bad-continuation)
C: 45, 0: Wrong continued indentation.
          # Linux ChromiumOS
          ^| (bad-continuation)
W: 61, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C:  1, 0: Missing module docstring (missing-docstring)
C: 10, 0: Invalid constant name "m_annotator" (invalid-name)
C: 12, 0: Invalid function name "Update" (invalid-name)
C: 12, 0: Invalid argument name "c" (invalid-name)
C: 12, 0: Missing function docstring (missing-docstring)
W: 10, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 11, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 12, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 13, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 14, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 16, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 17, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C:  9, 0: Missing class docstring (missing-docstring)
C: 14, 2: Invalid class attribute name
"alternate_tree_closing_notification_recipients" (invalid-name)
R:  9, 0: Too few public methods (0/2) (too-few-public-methods)
W: 10, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 11, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 12, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 13, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 14, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W: 15, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
C:  9, 0: Missing class docstring (missing-docstring)
R:  9, 0: Too few public methods (0/2) (too-few-public-methods)
************* Module master_win_drmemory_cfg
C: 42, 0: Wrong hanging indentation.
      'drmemory_light_…
(message too large)

[luqui, 2015-03-09 19:06:36]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-03-09 19:07:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985273002/80001

[luqui, 2015-03-09 19:10:04]

The CQ bit was unchecked by luqui@chromium.org

[luqui, 2015-03-09 19:10:40]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-03-09 19:18:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 19:18:15]

Presubmit check for 985273002-80001 failed and returned exit status -15.

Running presubmit commit checks ...

[luqui, 2015-03-09 19:18:47]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-03-09 19:19:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985273002/80001

[commit-bot: I haz the power, 2015-03-09 19:25:23]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294385