Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: dart/frog/leg/lib/string_helper.dart

Issue 9852018: Minor tweaks to the core library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/corelib/corelib-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/lib/string_helper.dart
diff --git a/dart/frog/leg/lib/string_helper.dart b/dart/frog/leg/lib/string_helper.dart
index fa1bfb7db8040d771312210663467ab441e3fe87..34932a56e6b30b618321a4a85962e69b4b110ccc 100644
--- a/dart/frog/leg/lib/string_helper.dart
+++ b/dart/frog/leg/lib/string_helper.dart
@@ -36,7 +36,7 @@ allMatchesInStringUnchecked(receiver, str) {
var result = new List();
ngeoffray 2012/03/25 18:22:17 This should be new List<Match>()
var length = receiver.length;
if (length === 0) {
- return result;
+ return [receiver];
ngeoffray 2012/03/25 18:22:17 receiver being a string and the returned type of t
Lasse Reichstein Nielsen 2012/03/25 18:22:41 Is [receiver] a Match object? Because it seems we
}
var strLength = str.length;
« no previous file with comments | « dart/frog/leg/lib/js_helper.dart ('k') | dart/tests/corelib/corelib-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698