Minor tweaks to the core library.

dart/frog/leg/lib/string_helper.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class StringMatch implements Match {
   const StringMatch(int this._start,
                     String this.str,
                     String this.pattern);
 
   int start() => _start;
@@ skipping 14 matching lines @@
       result.add(group(g));
     }
     return result;
   }
 
   final int _start;
   final String str;
   final String pattern;
 }
 
 allMatchesInStringUnchecked(receiver, str) {

[Lasse Reichstein Nielsen, 2012/03/25 18:22:41]

Could you add a comment to this method. The argument names aren't telling, so I
have no idea which is being looked for in what.
I'm assuming this finds instances of [str] in [receiver], and [receiver] is also
a string. (Or call them haystack and needle instead :)

   var result = new List();

[ngeoffray, 2012/03/25 18:22:17]

This should be new List<Match>()

   var length = receiver.length;
   if (length === 0) {
-    return result;
+    return [receiver];

[ngeoffray, 2012/03/25 18:22:17]

receiver being a string and the returned type of that method being a List of
Match, I'm not sure how this can be right.

[Lasse Reichstein Nielsen, 2012/03/25 18:22:41]

Is [receiver] a Match object? Because it seems we are returning a list of Match
objects below.

   }
 
   var strLength = str.length;
   for (var i = 0; i < strLength;) {
     var index = str.indexOf(receiver, i);
     if (index < 0) {
       return result;
     }
     result.add(new StringMatch(index, str, receiver));
     i = index + length;
@@ skipping 62 matching lines @@
 stringSplitUnchecked(receiver, pattern) {
   if (pattern is String) {
     return JS('List', @'#.split(#)', receiver, pattern);
   } else if (pattern is JSSyntaxRegExp) {
     var re = regExpGetNative(pattern);
     return JS('List', @'#.split(#)', receiver, re);
   } else {
     throw "StringImplementation.split(Pattern) UNIMPLEMENTED";
   }
 }