Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 9852004: Revert 128679 - Speculative revert. xcodebuilders hosed between r128678 - 128680 in GYP phse, this … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by Ryan Sleevi
Modified:
3 years ago
Reviewers:
John Grabowski
CC:
chromium-reviews, darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 128679 - Speculative revert. xcodebuilders hosed between r128678 - 128680 in GYP phse, this is the only change that touched GYP files. apk-based test runner work. Not enabled yet. This CL is a combination of upstreaming, ndk/ant-ification, and other tweaks. BUG=None TEST= Review URL: http://codereview.chromium.org/9834037 TBR=jrg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -489 lines) Patch
M base/base.gyp View 2 chunks +1 line, -2 lines 0 comments Download
D base/test/android/AndroidManifest.xml View 1 chunk +0 lines, -43 lines 0 comments Download
D base/test/android/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D base/test/android/java/org/chromium/ChromeNativeTestActivity.java View 1 chunk +0 lines, -47 lines 0 comments Download
D base/test/android/native_test.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D base/test/android/native_test_apk.xml View 1 chunk +0 lines, -37 lines 0 comments Download
D base/test/android/native_test_launcher.cc View 1 chunk +0 lines, -190 lines 0 comments Download
M build/all_android.gyp View 1 chunk +2 lines, -9 lines 0 comments Download
M build/android/envsetup.sh View 1 chunk +2 lines, -5 lines 0 comments Download
M build/android/run_tests.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/single_test_runner.py View 2 chunks +1 line, -10 lines 0 comments Download
M build/android/test_package.py View 2 chunks +1 line, -2 lines 0 comments Download
D build/android/test_package_apk.py View 1 chunk +0 lines, -89 lines 0 comments Download
M build/common.gypi View 2 chunks +3 lines, -8 lines 0 comments Download
M build/install-build-deps-android.sh View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
3 years ago (2012-03-24 04:44:33 UTC) #1
Ryan Sleevi
This was indeed responsible for the xcode break. After reverting, mac waterfall bots greened up.
3 years ago (2012-03-24 04:52:28 UTC) #2
Ryan Sleevi
Sample log from a mac bot: ________ running '/usr/bin/python src/build/gyp_chromium' in '/b/build/slave/cr-mac-rel/build' Updating projects from ...
3 years ago (2012-03-24 05:05:35 UTC) #3
Ryan Sleevi
3 years ago (2012-03-24 05:34:57 UTC) #4
also: check_deps failures on Windows

http://build.chromium.org/p/chromium/builders/Win7%20Tests%20%28dbg%29%281%29...

Using base directory: e:\b\build\slave\Win7_Tests__dbg__1_\build\src
Checking: e:\b\build\slave\Win7_Tests__dbg__1_\build\src
ERROR in
e:/b/build/slave/Win7_Tests__dbg__1_/build/src\base\test\android\native_test_launcher.cc
Illegal include: "gtest/gtest.h"
    Because of no rule applying
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted