Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: build/common.gypi

Issue 9852004: Revert 128679 - Speculative revert. xcodebuilders hosed between r128678 - 128680 in GYP phse, this … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/test_package_apk.py ('k') | build/install-build-deps-android.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 128684)
+++ build/common.gypi (working copy)
@@ -789,9 +789,9 @@
'notifications%': 0,
# Builds the gtest targets as a shared_library.
- # TODO(jrg): when 'gtest_target_type'=='shared_libary' and OS==android,
- # make all gtest_targets depend on base/base.gyp:native_test_apk.
- ### 'gtest_target_type': 'shared_libary',
+ # TODO(michaelbai): Use the fixed value 'shared_library' once it
+ # is fully supported.
+ 'gtest_target_type%': '<(gtest_target_type)',
# Uses system APIs for decoding audio and video.
'use_libffmpeg%': '0',
@@ -2356,11 +2356,6 @@
'ldflags': [
'-Wl,-shared,-Bsymbolic',
],
- # Use of -nostdlib prevents the compiler from bringing
- # in crtbegin_dynamic.o et al, so we get an undefined
- # reference to ___dso_handle when building
- # gtest_target_type==shared_library.
- 'ldflags!': [ '-nostdlib' ],
}],
],
}],
« no previous file with comments | « build/android/test_package_apk.py ('k') | build/install-build-deps-android.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698