Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
984553002:
Added helper scripts for modifying polymer_resources.grdp. (Closed)
|
Created:
5 years, 9 months ago by dzhioev (left Google) Modified:
5 years, 6 months ago CC:
chromium-reviews, oshima+watch_chromium.org, michaelpg+watch-polymer_chromium.org, Dan Beam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded helper scripts for modifying polymer_resources.grdp.
The first one, "polymer_grdp_to_txt.py", converts "polymer_resources.grdp" to a
plane list of used Polymer components:
...
core-animation/core-animation.html
core-animation/web-animations.html
core-collapse/core-collapse-extracted.js
core-collapse/core-collapse.css
core-collapse/core-collapse.html
core-dropdown/core-dropdown-base-extracted.js
...
The second, "txt_to_polymer_grdp.py", converts list back to grdp file.
Both scripts enforce correct alphabetical order.
BUG=none
NOPRESUBMIT=true
(long lines)
Committed: https://crrev.com/3f408e0259c930ad6dca686e481025b03ec7b106
Cr-Commit-Position: refs/heads/master@{#334514}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Rewritten in Python. #Patch Set 3 : newline #
Total comments: 10
Patch Set 4 : Comments addressed. #
Total comments: 9
Patch Set 5 : More changes. #
Total comments: 2
Patch Set 6 : Merge conflict resolved. #Patch Set 7 : Added 1.0 support. #Patch Set 8 : Rebased onto ToT. #Patch Set 9 : Rebased again. #
Total comments: 3
Messages
Total messages: 53 (19 generated)
dzhioev@chromium.org changed reviewers: + michaelpg@chromium.org
https://codereview.chromium.org/984553002/diff/1/tools/polymer/txt_to_polymer... File tools/polymer/txt_to_polymer_grdp.sh (right): https://codereview.chromium.org/984553002/diff/1/tools/polymer/txt_to_polymer... tools/polymer/txt_to_polymer_grdp.sh:16: cat "$1" | LC_ALL=C sort -u | while read p why not 'sort "$1"' instead of 'cat "$1" | sort'? https://codereview.chromium.org/984553002/diff/1/tools/polymer/txt_to_polymer... tools/polymer/txt_to_polymer_grdp.sh:26: file="../../../third_party/web-animations-js/sources/web-animations-next-lite.min.js" optional: maybe put these in a separate .txt file? https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... ui/webui/resources/polymer_resources.grdp:18: <structure name="IDR_POLYMER_CORE_ANIMATED_PAGES_CORE_ANIMATED_PAGES_EXTRACTED_JS" :-\ I guess it doesn't matter if we sort by file= (and using LC=ALL means we sort bytewise instead of dictionary-wise, e.g., "-" comes before "." here but we don't normally alphabetize that way) instead of name=? +dbeam in case he has thoughts.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
i think these scripts would be better off written in python: a) because we'll have a freakin clue what they're doing b) they'll work on windows
On 2015/03/06 17:41:15, Dan Beam wrote: > i think these scripts would be better off written in python: > a) because we'll have a freakin clue what they're doing > b) they'll work on windows Done, rewritten in Python. PTAL
https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... ui/webui/resources/polymer_resources.grdp:18: <structure name="IDR_POLYMER_CORE_ANIMATED_PAGES_CORE_ANIMATED_PAGES_EXTRACTED_JS" On 2015/03/06 04:09:31, michaelpg wrote: > :-\ I guess it doesn't matter if we sort by file= (and using LC=ALL means we > sort bytewise instead of dictionary-wise, e.g., "-" comes before "." here but we > don't normally alphabetize that way) instead of name=? > > +dbeam in case he has thoughts. New version sorts by 'name' using standard Python sort. Is it OK?
https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... ui/webui/resources/polymer_resources.grdp:18: <structure name="IDR_POLYMER_CORE_ANIMATED_PAGES_CORE_ANIMATED_PAGES_EXTRACTED_JS" On 2015/03/16 19:00:23, dzhioev wrote: > On 2015/03/06 04:09:31, michaelpg wrote: > > :-\ I guess it doesn't matter if we sort by file= (and using LC=ALL means we > > sort bytewise instead of dictionary-wise, e.g., "-" comes before "." here but > we > > don't normally alphabetize that way) instead of name=? > > > > +dbeam in case he has thoughts. > New version sorts by 'name' using standard Python sort. Is it OK? don't care, especially if a script does this for us. does this differ from anywhere else in Chrome? https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:2: # Copyright (c) 2015 The Chromium Authors. All rights reserved. remove "(c) " https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:8: \n\n between file-level globals: https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank... https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:23: if __name__ == '__main__': https://codereview.chromium.org/984553002/diff/40001/tools/polymer/txt_to_pol... File tools/polymer/txt_to_polymer_grdp.py (right): https://codereview.chromium.org/984553002/diff/40001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:53: if __name__ == '__main__': https://codereview.chromium.org/984553002/diff/40001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:54: paths = [p.strip() for p in open(sys.argv[1]) if p.strip()] what closes this file?
https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... File ui/webui/resources/polymer_resources.grdp (right): https://codereview.chromium.org/984553002/diff/1/ui/webui/resources/polymer_r... ui/webui/resources/polymer_resources.grdp:18: <structure name="IDR_POLYMER_CORE_ANIMATED_PAGES_CORE_ANIMATED_PAGES_EXTRACTED_JS" On 2015/03/16 19:28:09, Dan Beam wrote: > On 2015/03/16 19:00:23, dzhioev wrote: > > On 2015/03/06 04:09:31, michaelpg wrote: > > > :-\ I guess it doesn't matter if we sort by file= (and using LC=ALL means we > > > sort bytewise instead of dictionary-wise, e.g., "-" comes before "." here > but > > we > > > don't normally alphabetize that way) instead of name=? > > > > > > +dbeam in case he has thoughts. > > New version sorts by 'name' using standard Python sort. Is it OK? > > don't care, especially if a script does this for us. does this differ from > anywhere else in Chrome? I don't think we have a policy for that. Somewhere names are sorted and somewhere not. https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:2: # Copyright (c) 2015 The Chromium Authors. All rights reserved. On 2015/03/16 19:28:09, Dan Beam wrote: > remove "(c) " Done. https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:8: On 2015/03/16 19:28:09, Dan Beam wrote: > \n\n between file-level globals: > https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank... Done. https://codereview.chromium.org/984553002/diff/40001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:23: On 2015/03/16 19:28:10, Dan Beam wrote: > if __name__ == '__main__': Done. https://codereview.chromium.org/984553002/diff/40001/tools/polymer/txt_to_pol... File tools/polymer/txt_to_polymer_grdp.py (right): https://codereview.chromium.org/984553002/diff/40001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:53: On 2015/03/16 19:28:10, Dan Beam wrote: > if __name__ == '__main__': Done. https://codereview.chromium.org/984553002/diff/40001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:54: paths = [p.strip() for p in open(sys.argv[1]) if p.strip()] On 2015/03/16 19:28:10, Dan Beam wrote: > what closes this file? Fixed.
https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:34: sys.exit(main(sys.argv)) I don't think this is the way you're supposed to use sys.exit(): https://docs.python.org/2/library/sys.html#sys.exit https://codereview.chromium.org/984553002/diff/60001/tools/polymer/txt_to_pol... File tools/polymer/txt_to_polymer_grdp.py (right): https://codereview.chromium.org/984553002/diff/60001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:6: from __future__ import with_statement why is this necessary? just to use with? https://codereview.chromium.org/984553002/diff/60001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:61: paths = [p.strip() for p in f if p.strip()] what is this code doing? filtering out empty lines? filter(None, f.splitlines()) seems slightly easier to understand
https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:29: xml.sax.parse(sys.argv[1], xml_handler) Should be just "argv[1]". Fixed in the next patchset. https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:34: sys.exit(main(sys.argv)) On 2015/03/17 16:37:53, Dan Beam wrote: > I don't think this is the way you're supposed to use sys.exit(): > https://docs.python.org/2/library/sys.html#sys.exit I don't see what is wrong. main() can optionally return exit code. If it doesn't return anything, exit code will be 0. https://codereview.chromium.org/984553002/diff/60001/tools/polymer/txt_to_pol... File tools/polymer/txt_to_polymer_grdp.py (right): https://codereview.chromium.org/984553002/diff/60001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:6: from __future__ import with_statement On 2015/03/17 16:37:53, Dan Beam wrote: > why is this necessary? just to use with? Yep. https://codereview.chromium.org/984553002/diff/60001/tools/polymer/txt_to_pol... tools/polymer/txt_to_polymer_grdp.py:61: paths = [p.strip() for p in f if p.strip()] On 2015/03/17 16:37:53, Dan Beam wrote: > what is this code doing? filtering out empty lines? > > filter(None, f.splitlines()) > > seems slightly easier to understand Not only empty, but also whitespace-only lines. In addition it strips the lines, in case if somebody left trailing spaces. The meaning of None param in filter() is not obvious to me. Furthermore, Guido doesn't like filter() ( http://www.artima.com/weblogs/viewpost.jsp?thread=98196 ). Let's end up with [p.strip() for p in f if not p.isspace()].
lgtm https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:34: sys.exit(main(sys.argv)) On 2015/03/17 18:26:46, dzhioev wrote: > On 2015/03/17 16:37:53, Dan Beam wrote: > > I don't think this is the way you're supposed to use sys.exit(): > > https://docs.python.org/2/library/sys.html#sys.exit > > I don't see what is wrong. > main() can optionally return exit code. If it doesn't return anything, exit code > will be 0. > i guess None is 0-ish, yeah, but there's nothing that would actually return 1. this is similar to try/except when nothing can go wrong... what's the point? just messes with the reader. https://codereview.chromium.org/984553002/diff/80001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/80001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:11: nit: not sure if it's typical to put a \n here
lgtm
https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/60001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:34: sys.exit(main(sys.argv)) On 2015/03/17 18:37:53, Dan Beam wrote: > On 2015/03/17 18:26:46, dzhioev wrote: > > On 2015/03/17 16:37:53, Dan Beam wrote: > > > I don't think this is the way you're supposed to use sys.exit(): > > > https://docs.python.org/2/library/sys.html#sys.exit > > > > I don't see what is wrong. > > main() can optionally return exit code. If it doesn't return anything, exit > code > > will be 0. > > > > i guess None is 0-ish, yeah, but there's nothing that would actually return 1. > > this is similar to try/except when nothing can go wrong... what's the point? > just messes with the reader. Probably such construction is idiomatic in Python. There are hundreds of "sys.exit(main(" in Chromium sources and often main() doesn't return anything. https://codereview.chromium.org/984553002/diff/80001/tools/polymer/polymer_gr... File tools/polymer/polymer_grdp_to_txt.py (right): https://codereview.chromium.org/984553002/diff/80001/tools/polymer/polymer_gr... tools/polymer/polymer_grdp_to_txt.py:11: On 2015/03/17 18:37:54, Dan Beam wrote: > nit: not sure if it's typical to put a \n here "One blank line between method definitions and between the class line and the first method." https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank...
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984553002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by dzhioev@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/984553002/#ps100001 (title: "Merge conflict resolved.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984553002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
ping. any reason not to submit this?
The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/984553002/#ps120001 (title: "Added 1.0 support.")
Michael, could you please take another look. I've adapted the tools to work with both 0.5 and 1.0 versions. I promise, I'll land the CL this time =)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984553002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/984553002/#ps140001 (title: "Rebased onto ToT.")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984553002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Michael, I'm committing this CL since you are OOO. Please take a look when you are back.
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984553002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by dzhioev@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/984553002/#ps160001 (title: "Rebased again.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984553002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984553002/160001
https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... File tools/polymer/txt_to_polymer_grdp.py (right): https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... tools/polymer/txt_to_polymer_grdp.py:46: file="../../../third_party/web-animations-js/sources/web-animations-next-lite.min.js.map" the presubmit is not fond of your examples... perhaps shorten?
https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... File tools/polymer/txt_to_polymer_grdp.py (right): https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... tools/polymer/txt_to_polymer_grdp.py:46: file="../../../third_party/web-animations-js/sources/web-animations-next-lite.min.js.map" On 2015/06/16 00:09:18, Dan Beam wrote: > the presubmit is not fond of your examples... perhaps shorten? Unfortunately this is not an example, but a part of generated file, so I can't shorten it.
https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... File tools/polymer/txt_to_polymer_grdp.py (right): https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... tools/polymer/txt_to_polymer_grdp.py:46: file="../../../third_party/web-animations-js/sources/web-animations-next-lite.min.js.map" On 2015/06/16 00:18:16, dzhioev wrote: > On 2015/06/16 00:09:18, Dan Beam wrote: > > the presubmit is not fond of your examples... perhaps shorten? > > Unfortunately this is not an example, but a part of generated file, so I can't > shorten it. ah, either do some string splitting magic or NOPRESUBMIT=true then?
On 2015/06/16 00:19:40, Dan Beam wrote: > https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... > File tools/polymer/txt_to_polymer_grdp.py (right): > > https://codereview.chromium.org/984553002/diff/160001/tools/polymer/txt_to_po... > tools/polymer/txt_to_polymer_grdp.py:46: > file="../../../third_party/web-animations-js/sources/web-animations-next-lite.min.js.map" > On 2015/06/16 00:18:16, dzhioev wrote: > > On 2015/06/16 00:09:18, Dan Beam wrote: > > > the presubmit is not fond of your examples... perhaps shorten? > > > > Unfortunately this is not an example, but a part of generated file, so I can't > > shorten it. > > ah, either do some string splitting magic or NOPRESUBMIT=true then? Yep, already set NOPRESUBMIT=true .
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/3f408e0259c930ad6dca686e481025b03ec7b106 Cr-Commit-Position: refs/heads/master@{#334514} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
