Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9845029: Fixes two type warnings in test_runner.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: added comment to explain fields[7] Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 34d193dda321534ecf0e4ff69eb8f2070262606e..1146584eb442d2f7334eb65ca3c966d4a5ef040d 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -329,14 +329,16 @@ class AnalysisTestOutputImpl extends TestOutputImpl {
// Read the returned list of errors and stuff them away.
for (String line in super.stderr) {
if (line.length == 0) continue;
+ // An error line has 8 fields that look like:
+ // ERROR|COMPILER|MISSING_SOURCE|file:/tmp/t.dart|15|1|24|Missing source.
List<String> fields = splitMachineError(line);
if (fields[0] == 'ERROR') {
- errors.add(fields);
+ errors.add(fields[7]);
} else if (fields[0] == 'WARNING') {
// We only care about testing Static type warnings
// ignore all others
if (fields[1] == 'STATIC_TYPE') {
- staticWarnings.add(fields);
+ staticWarnings.add(fields[7]);
}
}
// OK to Skip error output that doesn't match the machine format
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698