Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 9845029: Fixes two type warnings in test_runner.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: added comment to explain fields[7] Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 322
323 bool _didFail() { 323 bool _didFail() {
324 if (hasCrashed) return false; 324 if (hasCrashed) return false;
325 325
326 List<String> errors = []; 326 List<String> errors = [];
327 List<String> staticWarnings = []; 327 List<String> staticWarnings = [];
328 328
329 // Read the returned list of errors and stuff them away. 329 // Read the returned list of errors and stuff them away.
330 for (String line in super.stderr) { 330 for (String line in super.stderr) {
331 if (line.length == 0) continue; 331 if (line.length == 0) continue;
332 // An error line has 8 fields that look like:
333 // ERROR|COMPILER|MISSING_SOURCE|file:/tmp/t.dart|15|1|24|Missing source.
332 List<String> fields = splitMachineError(line); 334 List<String> fields = splitMachineError(line);
333 if (fields[0] == 'ERROR') { 335 if (fields[0] == 'ERROR') {
334 errors.add(fields); 336 errors.add(fields[7]);
335 } else if (fields[0] == 'WARNING') { 337 } else if (fields[0] == 'WARNING') {
336 // We only care about testing Static type warnings 338 // We only care about testing Static type warnings
337 // ignore all others 339 // ignore all others
338 if (fields[1] == 'STATIC_TYPE') { 340 if (fields[1] == 'STATIC_TYPE') {
339 staticWarnings.add(fields); 341 staticWarnings.add(fields[7]);
340 } 342 }
341 } 343 }
342 // OK to Skip error output that doesn't match the machine format 344 // OK to Skip error output that doesn't match the machine format
343 } 345 }
344 if (testCase.info != null 346 if (testCase.info != null
345 && testCase.info.optionsFromFile['isMultitest']) { 347 && testCase.info.optionsFromFile['isMultitest']) {
346 return _didMultitestFail(errors, staticWarnings); 348 return _didMultitestFail(errors, staticWarnings);
347 } 349 }
348 return _didStandardTestFail(errors, staticWarnings); 350 return _didStandardTestFail(errors, staticWarnings);
349 } 351 }
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 // the developer doesn't waste his or her time trying to fix a bunch of 1106 // the developer doesn't waste his or her time trying to fix a bunch of
1105 // tests that appear to be broken but were actually just flakes that 1107 // tests that appear to be broken but were actually just flakes that
1106 // didn't get retried because there had already been one failure. 1108 // didn't get retried because there had already been one failure.
1107 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1109 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1108 new RunningProcess(test, allowRetry, this).start(); 1110 new RunningProcess(test, allowRetry, this).start();
1109 } 1111 }
1110 _numProcesses++; 1112 _numProcesses++;
1111 } 1113 }
1112 } 1114 }
1113 } 1115 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698