Move files inside chrome/browser/chromeos/dbus to chromeos/dbus

Move files inside chrome/browser/chromeos/dbus to chromeos/dbus

Move files in chrome/browser/chromeos/dbus/ to chromeos/dbus
Add chromeos/dbus/DEPS
Add chromeos.gyp:chromeos_test_support and chromeos.gyp:chromeos_unittests
Add CHROMEOS_EXPORT to classes
Move power related proto targets to chromeos.gyp
Rewrite and sort #includes

BUG=119583
TEST=component chromeos build success, checkdeps success

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131065

[hashimoto, 2012-03-24 02:32:33]

This change depends on following changes:
 http://codereview.chromium.org/9839064/
 http://codereview.chromium.org/9839075/
 http://codereview.chromium.org/9837075/

[oshima, 2012-03-24 06:59:16]

On 2012/03/24 02:32:33, hashimoto wrote:
> This change depends on following changes:
>  http://codereview.chromium.org/9839064/
>  http://codereview.chromium.org/9839075/
>  http://codereview.chromium.org/9837075/

i'll review this after other changes are in

[oshima, 2012-03-24 07:00:08]

but one comment we can fix now :)

http://codereview.chromium.org/9838085/diff/279/chromeos/dbus/DEPS
File chromeos/dbus/DEPS (right):

http://codereview.chromium.org/9838085/diff/279/chromeos/dbus/DEPS#newcode2
chromeos/dbus/DEPS:2: "+base",
base is not necessary. it's in DPES in the root.

[hashimoto, 2012-04-05 22:31:52]

New patch set, PTAL!

Most of changes are simple include fix.
Please review gyp files intensively.

[hashimoto, 2012-04-05 22:43:29]

Sorry, there was an error in chrome_tests.gypi.
Uploaded a new patch.

[oshima, 2012-04-05 23:30:46]

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/chromeos/pro...
File chrome/browser/chromeos/proxy_config_service_impl_unittest.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/chromeos/pro...
chrome/browser/chromeos/proxy_config_service_impl_unittest.cc:1: // Copyright
(c) 2011 The Chromium Authors. All rights reserved.
2012  check other files as well.

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/idle_chromeo...
File chrome/browser/idle_chromeos.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:13: #endif
looks like this (and code below) is dead code. Can you remove them?

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp#newco...
chromeos/chromeos.gyp:124: 'target_name': 'chromeos_unittests',
add this to aura_builder target, and please file a request to run this test on
all chromeos bots.

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_bluetoot...
File chromeos/dbus/mock_bluetooth_manager_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_bluetoot...
chromeos/dbus/mock_bluetooth_manager_client.cc:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
2012

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
File chromeos/dbus/mock_cros_disks_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
chromeos/dbus/mock_cros_disks_client.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
ditto

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
File chromeos/dbus/mock_cros_disks_client.h (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
chromeos/dbus/mock_cros_disks_client.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
2012

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_speech_s...
File chromeos/dbus/mock_speech_synthesizer_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_speech_s...
chromeos/dbus/mock_speech_synthesizer_client.cc:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
ditto

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
File chromeos/dbus/mock_update_engine_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
chromeos/dbus/mock_update_engine_client.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
ditto

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
File chromeos/dbus/mock_update_engine_client.h (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
chromeos/dbus/mock_update_engine_client.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
ditto

[hashimoto, 2012-04-06 00:19:24]

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/chromeos/pro...
File chrome/browser/chromeos/proxy_config_service_impl_unittest.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/chromeos/pro...
chrome/browser/chromeos/proxy_config_service_impl_unittest.cc:1: // Copyright
(c) 2011 The Chromium Authors. All rights reserved.
On 2012/04/05 23:30:46, oshima wrote:
> 2012  check other files as well.

Done.

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/idle_chromeo...
File chrome/browser/idle_chromeos.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:13: #endif
On 2012/04/05 23:30:46, oshima wrote:
> looks like this (and code below) is dead code. Can you remove them?

Done.

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp#newco...
chromeos/chromeos.gyp:124: 'target_name': 'chromeos_unittests',
On 2012/04/05 23:30:46, oshima wrote:
> add this to aura_builder target, and please file a request to run this test on
> all chromeos bots.

Added.
Where should I file a request, crbug.com?

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_bluetoot...
File chromeos/dbus/mock_bluetooth_manager_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_bluetoot...
chromeos/dbus/mock_bluetooth_manager_client.cc:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
On 2012/04/05 23:30:46, oshima wrote:
> 2012

Done.

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
File chromeos/dbus/mock_cros_disks_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
chromeos/dbus/mock_cros_disks_client.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/04/05 23:30:46, oshima wrote:
> ditto

Done.

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
File chromeos/dbus/mock_cros_disks_client.h (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_cros_dis...
chromeos/dbus/mock_cros_disks_client.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/04/05 23:30:46, oshima wrote:
> 2012

Done.

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_speech_s...
File chromeos/dbus/mock_speech_synthesizer_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_speech_s...
chromeos/dbus/mock_speech_synthesizer_client.cc:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
On 2012/04/05 23:30:46, oshima wrote:
> ditto

Done.

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
File chromeos/dbus/mock_update_engine_client.cc (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
chromeos/dbus/mock_update_engine_client.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/04/05 23:30:46, oshima wrote:
> ditto

Done.

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
File chromeos/dbus/mock_update_engine_client.h (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/dbus/mock_update_e...
chromeos/dbus/mock_update_engine_client.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/04/05 23:30:46, oshima wrote:
> ditto

Done.

[oshima, 2012-04-06 00:38:48]

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp#newco...
chromeos/chromeos.gyp:124: 'target_name': 'chromeos_unittests',
On 2012/04/06 00:19:24, hashimoto wrote:
> On 2012/04/05 23:30:46, oshima wrote:
> > add this to aura_builder target, and please file a request to run this test
on
> > all chromeos bots.
> 
> Added.
> Where should I file a request, crbug.com?

yes, assign it to petermayo with label Build-Infrastructure

http://codereview.chromium.org/9838085/diff/26276/chrome/browser/idle_chromeo...
File chrome/browser/idle_chromeos.cc (right):

http://codereview.chromium.org/9838085/diff/26276/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:28: }
you can remove this if block now?

http://codereview.chromium.org/9838085/diff/26276/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:40: return
ScreensaverWindowFinder::ScreensaverWindowExists();
ditto

[hashimoto, 2012-04-06 00:47:41]

http://codereview.chromium.org/9838085/diff/26276/chrome/browser/idle_chromeo...
File chrome/browser/idle_chromeos.cc (right):

http://codereview.chromium.org/9838085/diff/26276/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:28: }
On 2012/04/06 00:38:49, oshima wrote:
> you can remove this if block now?

Done.

http://codereview.chromium.org/9838085/diff/26276/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:40: return
ScreensaverWindowFinder::ScreensaverWindowExists();
On 2012/04/06 00:38:49, oshima wrote:
> ditto

Done.

[hashimoto, 2012-04-06 00:52:02]

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

http://codereview.chromium.org/9838085/diff/25261/chromeos/chromeos.gyp#newco...
chromeos/chromeos.gyp:124: 'target_name': 'chromeos_unittests',
On 2012/04/06 00:38:49, oshima wrote:
> On 2012/04/06 00:19:24, hashimoto wrote:
> > On 2012/04/05 23:30:46, oshima wrote:
> > > add this to aura_builder target, and please file a request to run this
test
> on
> > > all chromeos bots.
> > 
> > Added.
> > Where should I file a request, crbug.com?
> 
> yes, assign it to petermayo with label Build-Infrastructure

Filed http://crbug.com/122279

[oshima, 2012-04-06 00:58:09]

LGTM with one more request.

http://codereview.chromium.org/9838085/diff/26277/chrome/browser/idle_chromeo...
File chrome/browser/idle_chromeos.cc (left):

http://codereview.chromium.org/9838085/diff/26277/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:39: // check if the workstation is locked.
Please keep this comment. Please add TODO(oshima) and say verify if this
behavior is correct.

[hashimoto, 2012-04-06 01:06:07]

Done, going to commit this.

http://codereview.chromium.org/9838085/diff/26277/chrome/browser/idle_chromeo...
File chrome/browser/idle_chromeos.cc (left):

http://codereview.chromium.org/9838085/diff/26277/chrome/browser/idle_chromeo...
chrome/browser/idle_chromeos.cc:39: // check if the workstation is locked.
On 2012/04/06 00:58:09, oshima wrote:
> Please keep this comment. Please add TODO(oshima) and say verify if this
> behavior is correct.

Done.