content/browser/tab_contents/tab_contents_view_helper.cc - Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/tab_contents_view_helper.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised approach based on http://crrev.com/125180. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « content/browser/renderer_host/render_widget_helper.cc ('k') | content/public/browser/content_browser_client.h » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tab_contents/tab_contents_view_helper.cc

diff --git a/content/browser/tab_contents/tab_contents_view_helper.cc b/content/browser/tab_contents/tab_contents_view_helper.cc

index beb9ca3607b1dfdfc5da85233b371b8fd3e45ac0..beaae80fa8fab1ff4936ca108c13f53933192bee 100644

--- a/content/browser/tab_contents/tab_contents_view_helper.cc

+++ b/content/browser/tab_contents/tab_contents_view_helper.cc

@@ -56,7 +56,8 @@ TabContents* TabContentsViewHelper::CreateNewWindow(

web_contents,

route_id,

params.window_container_type,

- params.frame_name);

+ params.frame_name,

+ params.target_url);

}

if (!should_create)