chrome/common/extensions/extension_manifests_unittest.cc - Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised approach based on http://crrev.com/125180. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/common/extensions/extension_manifest_constants.cc ('k') | chrome/test/data/extensions/api_test/app_background_page/no_js/bg.html » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_manifests_unittest.cc

diff --git a/chrome/common/extensions/extension_manifests_unittest.cc b/chrome/common/extensions/extension_manifests_unittest.cc

index 351a770713a4cb2e0ca025b2a145c0b2623a15ab..05145c6f3c41bc447f82f48d97c4eba55b66255a 100644

--- a/chrome/common/extensions/extension_manifests_unittest.cc

+++ b/chrome/common/extensions/extension_manifests_unittest.cc

@@ -1107,6 +1107,10 @@ TEST_F(ExtensionManifestTest, BackgroundAllowNoJsAccess) {

extension = LoadAndExpectSuccess("background_allow_no_js_access.json");

ASSERT_TRUE(extension);

EXPECT_FALSE(extension->allow_background_js_access());

+ extension = LoadAndExpectSuccess("background_allow_no_js_access2.json");

+ ASSERT_TRUE(extension);

+ EXPECT_FALSE(extension->allow_background_js_access());

}

TEST_F(ExtensionManifestTest, PageActionManifestVersion2) {