Issue 9837059: Cleanup for views::Label:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9837059: Cleanup for views::Label: (Closed)

Created:
8 years, 9 months ago by Peter Kasting

Modified:
8 years, 9 months ago

Reviewers:
stevenjb, sky

CC:
chromium-reviews, asanka, tfarina, Randy Smith (Not in Mondays)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup for views::Label: * Eliminate unused GetURL() function * Simplify and inline GetText(), since the extra work it did for URLs was already done in SetURL() * Eliminate |url_set_|, just switch based on whether the |url_| is empty BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129009

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -45 lines)			Patch
M	chrome/browser/chromeos/status/status_area_bubble.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_item_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/generic_info_view_unittest.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/selected_keyword_view.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/views/controls/label.h	View		2 chunks	+4 lines, -8 lines	0 comments	Download
M	ui/views/controls/label.cc	View		4 chunks	+4 lines, -13 lines	0 comments	Download
M	ui/views/controls/label_unittest.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ui/views/controls/message_box_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

owner LGTM for status

Expand Messages | Collapse Messages