Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/ui/views/location_bar/selected_keyword_view.cc

Issue 9837059: Cleanup for views::Label: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | ui/views/controls/label.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/selected_keyword_view.h" 5 #include "chrome/browser/ui/views/location_bar/selected_keyword_view.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/search_engines/template_url_service.h" 9 #include "chrome/browser/search_engines/template_url_service.h"
10 #include "chrome/browser/search_engines/template_url_service_factory.h" 10 #include "chrome/browser/search_engines/template_url_service_factory.h"
(...skipping 28 matching lines...) Expand all
39 return size; 39 return size;
40 } 40 }
41 41
42 gfx::Size SelectedKeywordView::GetMinimumSize() { 42 gfx::Size SelectedKeywordView::GetMinimumSize() {
43 gfx::Size size(GetNonLabelSize()); 43 gfx::Size size(GetNonLabelSize());
44 size.Enlarge(partial_label_.GetMinimumSize().width(), 0); 44 size.Enlarge(partial_label_.GetMinimumSize().width(), 0);
45 return size; 45 return size;
46 } 46 }
47 47
48 void SelectedKeywordView::Layout() { 48 void SelectedKeywordView::Layout() {
49 SetLabel((width() == GetPreferredSize().width()) ? 49 SetLabel(((width() == GetPreferredSize().width()) ?
50 full_label_.GetText() : partial_label_.GetText()); 50 full_label_ : partial_label_).text());
51 IconLabelBubbleView::Layout(); 51 IconLabelBubbleView::Layout();
52 } 52 }
53 53
54 void SelectedKeywordView::SetKeyword(const string16& keyword) { 54 void SelectedKeywordView::SetKeyword(const string16& keyword) {
55 keyword_ = keyword; 55 keyword_ = keyword;
56 if (keyword.empty()) 56 if (keyword.empty())
57 return; 57 return;
58 DCHECK(profile_); 58 DCHECK(profile_);
59 TemplateURLService* model = 59 TemplateURLService* model =
60 TemplateURLServiceFactory::GetForProfile(profile_); 60 TemplateURLServiceFactory::GetForProfile(profile_);
61 if (!model) 61 if (!model)
62 return; 62 return;
63 63
64 bool is_extension_keyword; 64 bool is_extension_keyword;
65 const string16 short_name = model->GetKeywordShortName(keyword, 65 const string16 short_name = model->GetKeywordShortName(keyword,
66 &is_extension_keyword); 66 &is_extension_keyword);
67 int message_id = is_extension_keyword ? 67 int message_id = is_extension_keyword ?
68 IDS_OMNIBOX_EXTENSION_KEYWORD_TEXT : IDS_OMNIBOX_KEYWORD_TEXT; 68 IDS_OMNIBOX_EXTENSION_KEYWORD_TEXT : IDS_OMNIBOX_KEYWORD_TEXT;
69 full_label_.SetText( 69 full_label_.SetText(
70 l10n_util::GetStringFUTF16(message_id, short_name)); 70 l10n_util::GetStringFUTF16(message_id, short_name));
71 const std::wstring min_string( 71 const std::wstring min_string(
72 location_bar_util::CalculateMinString(UTF16ToWide(short_name))); 72 location_bar_util::CalculateMinString(UTF16ToWide(short_name)));
73 partial_label_.SetText(min_string.empty() ? 73 partial_label_.SetText(min_string.empty() ?
74 full_label_.GetText() : 74 full_label_.text() :
75 l10n_util::GetStringFUTF16(message_id, WideToUTF16(min_string))); 75 l10n_util::GetStringFUTF16(message_id, WideToUTF16(min_string)));
76 } 76 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | ui/views/controls/label.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698