Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 9837043: Initialize bitmap to (0, 0, 0, 0) for CanvasPaintT<T> instances. (Closed)

Created:
8 years, 9 months ago by Jeff Timanus
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Default initialize CanvasPaintT<T> bitmaps to 0, 0, 0, 0. PlatformCanvas objects are constructed uninitialized. (Since change http://src.chromium.org/viewvc/chrome?view=rev&revision=127196). This change had propagated uninitialized semantics to CanvasPaint<..>, and CanvasPaintSkia, which introduced the regressions mentioned in the bug below. This change re-introduces the initilized memory behaviour, but at the CanvasPaint<T> level. This preserves the performance boost from rev 127196, and prevents regressions in displayed UI elements. Change also removes a now-unnecessary clear in browser_action_button.mm introduced by http://codereview.chromium.org/9839012. BUG=118755 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128574

Patch Set 1 #

Patch Set 2 : Remove unneeded clear for extension icons. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/canvas_paint_gtk.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M skia/ext/canvas_paint_mac.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M skia/ext/canvas_paint_wayland.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M skia/ext/canvas_paint_win.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M skia/ext/canvas_paint_x.h View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jeff Timanus
Robert, can you please rubber-stamp the change browser-action-button change? Stephen, there isn't much to see ...
8 years, 9 months ago (2012-03-23 17:15:45 UTC) #1
Stephen White
On 2012/03/23 17:15:45, Jeff Timanus wrote: > Robert, can you please rubber-stamp the change browser-action-button ...
8 years, 9 months ago (2012-03-23 17:26:22 UTC) #2
Jeff Timanus
On 2012/03/23 17:26:22, Stephen White wrote: > On 2012/03/23 17:15:45, Jeff Timanus wrote: > > ...
8 years, 9 months ago (2012-03-23 17:43:43 UTC) #3
senorblanco
On 2012/03/23 17:43:43, Jeff Timanus wrote: > On 2012/03/23 17:26:22, Stephen White wrote: > > ...
8 years, 9 months ago (2012-03-23 18:10:28 UTC) #4
Robert Sesek
lgtm cocoa/ lgtm
8 years, 9 months ago (2012-03-23 18:31:05 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-23 18:54:37 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698