Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: skia/ext/canvas_paint_gtk.h

Issue 9837043: Initialize bitmap to (0, 0, 0, 0) for CanvasPaintT<T> instances. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove unneeded clear for extension icons. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_button.mm ('k') | skia/ext/canvas_paint_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/canvas_paint_gtk.h
===================================================================
--- skia/ext/canvas_paint_gtk.h (revision 128476)
+++ skia/ext/canvas_paint_gtk.h (working copy)
@@ -18,6 +18,7 @@
// A class designed to translate skia painting into a region in a GdkWindow.
// On construction, it will set up a context for painting into, and on
// destruction, it will commit it to the GdkWindow.
+// Note: The created context is always inialized to (0, 0, 0, 0).
template <class T>
class CanvasPaintT : public T {
public:
@@ -89,6 +90,8 @@
// Cause a deliberate crash;
CHECK(false);
}
+ // No need to clear the canvas, because cairo automatically performs the
+ // clear.
// Need to translate so that the dirty region appears at the origin of the
// surface.
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_button.mm ('k') | skia/ext/canvas_paint_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698