AnalysisServer fixes

AnalysisServer fixes

[danrubel, 2012-03-27 04:26:06]

* resolve multiple libraries at once
* construct library with short URI if one exists
* include all imported libraries during resolution

[scheglov, 2012-03-27 04:54:06]

LGTM

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1165: Map<URI,
LibraryUnit> newLibraries = new HashMap<URI, LibraryUnit>();
Why not use Maps.newHashMap() and save repeating type arguments?

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1170:
System.out.println("Resolved " + libUri);
debug output left

[Brian Wilkerson, 2012-03-27 14:00:18]

LGTM

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1169: if
(!resolvedLibs.containsKey(libUri) && libUnit != null) {
I don't know this code yet, so these questions might be naive. Do we need to add
libUri to resolvedLibs? Do we need to handle diet-parsed units (or have we
gotten rid of that concept)?

[danrubel, 2012-03-27 14:27:25]

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1165: Map<URI,
LibraryUnit> newLibraries = new HashMap<URI, LibraryUnit>();
On 2012/03/27 04:54:06, scheglov wrote:
> Why not use Maps.newHashMap() and save repeating type arguments?

Good suggestion. Done.

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1169: if
(!resolvedLibs.containsKey(libUri) && libUnit != null) {
On 2012/03/27 14:00:18, Brian Wilkerson wrote:
> Do we need to add libUri to resolvedLibs?

No. resolvedLibs is built by the caller and not modified by this method.

> Do we need to handle diet-parsed units (or have we
> gotten rid of that concept)?

There are no diet parse units flowing through here, and we are eventually
removing them.

https://chromiumcodereview.appspot.com/9836105/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1170:
System.out.println("Resolved " + libUri);
On 2012/03/27 04:54:06, scheglov wrote:
> debug output left

Removed.

[danrubel, 2012-03-27 14:38:04]

Moved to https://chromiumcodereview.appspot.com/9860034/