Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6368)

Unified Diff: chrome_frame/chrome_frame_automation.cc

Issue 9836037: Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chr… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments from Greg Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/policy_test_cases.py ('k') | chrome_frame/chrome_frame_launcher.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_automation.cc
diff --git a/chrome_frame/chrome_frame_automation.cc b/chrome_frame/chrome_frame_automation.cc
index b4d302300e173ac3eac986f366b014c1a89ed6b6..88f5f9c5a6677559e3c0f99378d5d72241509182 100644
--- a/chrome_frame/chrome_frame_automation.cc
+++ b/chrome_frame/chrome_frame_automation.cc
@@ -519,7 +519,13 @@ bool ProxyFactory::ReleaseAutomationServer(void* server_id,
Vector::ContainerType::iterator it = std::find(proxies_.container().begin(),
proxies_.container().end(),
entry);
- proxies_.container().erase(it);
+ if (it != proxies_.container().end()) {
+ proxies_.container().erase(it);
+ } else {
+ DLOG(ERROR) << "Proxy wasn't found. Proxy map is likely empty (size="
+ << proxies_.container().size() << ").";
+ }
+
lock_.Release();
}
« no previous file with comments | « chrome/test/functional/policy_test_cases.py ('k') | chrome_frame/chrome_frame_launcher.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698