Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome_frame/chrome_frame_automation.cc

Issue 9836037: Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chr… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments from Greg Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/functional/policy_test_cases.py ('k') | chrome_frame/chrome_frame_launcher.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome_frame/chrome_frame_automation.h" 5 #include "chrome_frame/chrome_frame_automation.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 base::Bind(&AutomationProxyCacheEntry::RemoveDelegate, 512 base::Bind(&AutomationProxyCacheEntry::RemoveDelegate,
513 base::Unretained(entry), delegate, &done, &last_delegate)); 513 base::Unretained(entry), delegate, &done, &last_delegate));
514 done.Wait(); 514 done.Wait();
515 } 515 }
516 516
517 if (last_delegate) { 517 if (last_delegate) {
518 lock_.Acquire(); 518 lock_.Acquire();
519 Vector::ContainerType::iterator it = std::find(proxies_.container().begin(), 519 Vector::ContainerType::iterator it = std::find(proxies_.container().begin(),
520 proxies_.container().end(), 520 proxies_.container().end(),
521 entry); 521 entry);
522 proxies_.container().erase(it); 522 if (it != proxies_.container().end()) {
523 proxies_.container().erase(it);
524 } else {
525 DLOG(ERROR) << "Proxy wasn't found. Proxy map is likely empty (size="
526 << proxies_.container().size() << ").";
527 }
528
523 lock_.Release(); 529 lock_.Release();
524 } 530 }
525 531
526 entry->Release(); 532 entry->Release();
527 533
528 return true; 534 return true;
529 } 535 }
530 536
531 static base::LazyInstance<ProxyFactory>::Leaky 537 static base::LazyInstance<ProxyFactory>::Leaky
532 g_proxy_factory = LAZY_INSTANCE_INITIALIZER; 538 g_proxy_factory = LAZY_INSTANCE_INITIALIZER;
(...skipping 791 matching lines...) Expand 10 before | Expand all | Expand 10 after
1324 const net::URLRequestStatus& status) { 1330 const net::URLRequestStatus& status) {
1325 automation_server_->Send(new AutomationMsg_RequestEnd( 1331 automation_server_->Send(new AutomationMsg_RequestEnd(
1326 tab_->handle(), request_id, status)); 1332 tab_->handle(), request_id, status));
1327 } 1333 }
1328 1334
1329 void ChromeFrameAutomationClient::OnCookiesRetrieved(bool success, 1335 void ChromeFrameAutomationClient::OnCookiesRetrieved(bool success,
1330 const GURL& url, const std::string& cookie_string, int cookie_id) { 1336 const GURL& url, const std::string& cookie_string, int cookie_id) {
1331 automation_server_->Send(new AutomationMsg_GetCookiesHostResponse( 1337 automation_server_->Send(new AutomationMsg_GetCookiesHostResponse(
1332 tab_->handle(), success, url, cookie_string, cookie_id)); 1338 tab_->handle(), success, url, cookie_string, cookie_id));
1333 } 1339 }
OLDNEW
« no previous file with comments | « chrome/test/functional/policy_test_cases.py ('k') | chrome_frame/chrome_frame_launcher.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698