Issue 9835085: Revert 128696 - roll clang 151385:153254 due to mac sizes regression

Issue 9835085: Revert 128696 - roll clang 151385:153254 due to mac sizes regression (Closed)

Created:
8 years, 9 months ago by Rick Byers

Modified:
8 years, 9 months ago

Reviewers:
Nico

CC:
chromium-reviews, fischman+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 128696 - roll clang 151385:153254 due to mac sizes regression Caused a ~250kB regression in ChromiumFramework size, reverting to get the tree green. --- New stuff: * ObjC number, array, dict literals * ASan fixes, visibility fixes (see bugs) * (c++11: User-defined literals) * -Wstring-plus-int * Fix for a bug that made the last roll not work with goma BUG=114996, 112539, 119119 TEST=none Review URL: http://codereview.chromium.org/9836038 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128746

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
	M	build/common.gypi	View		2 chunks	+0 lines, -8 lines	0 comments	Download
	M	tools/clang/scripts/update.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

8 years, 9 months ago (2012-03-26 17:23:40 UTC) #2

LGTM

On Sat, Mar 24, 2012 at 9:17 AM,  <rbyers@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Revert 128696 - roll clang 151385:153254 due to mac sizes regression
>
> Caused a ~250kB regression in ChromiumFramework size, reverting to get the
> tree
> green.
> ---
>
> New stuff:
> * ObjC number, array, dict literals
> * ASan fixes, visibility fixes (see bugs)
> * (c++11: User-defined literals)
> * -Wstring-plus-int
> * Fix for a bug that made the last roll not work with goma
>
> BUG=114996,112539,119119
> TEST=none
>
> Review URL: http://codereview.chromium.org/9836038
>
> TBR=thakis@chromium.org
>
> Please review this at https://chromiumcodereview.appspot.com/9835085/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     build/common.gypi
>  M     tools/clang/scripts/update.sh
>
>
> Index: build/common.gypi
> ===================================================================
> --- build/common.gypi   (revision 128745)
> +++ build/common.gypi   (working copy)
> @@ -2052,10 +2052,6 @@
>               # Invalid() in gmocks's gmock-internal-utils.h
>               # http://crbug.com/111806
>               '-Wno-null-dereference',
> -
> -              # TODO(thakis): Investigate if it's worth cleaning up the
> code
> -              # and turning this on.
> -              '-Wno-null-conversion',
>             ],
>             'cflags!': [
>               # Clang doesn't seem to know know this flag.
> @@ -2475,10 +2471,6 @@
>                 # Invalid() in gmock's gmock-internal-utils.h
>                 # http://crbug.com/111806
>                 '-Wno-null-dereference',
> -
> -                # TODO(thakis): Investigate if it's worth cleaning up the
> code
> -                # and turning this on.
> -                '-Wno-null-conversion',
>               ],
>             }],
>             ['clang==1 and clang_use_chrome_plugins==1', {
> Index: tools/clang/scripts/update.sh
> ===================================================================
> --- tools/clang/scripts/update.sh       (revision 128745)
> +++ tools/clang/scripts/update.sh       (working copy)
> @@ -8,7 +8,7 @@
>  # Do NOT CHANGE this if you don't know what you're doing -- see
>  # https://code.google.com/p/chromium/wiki/UpdatingClang
>  # Reverting problematic clang rolls is safe, though.
> -CLANG_REVISION=153254
> +CLANG_REVISION=151385
>
>  THIS_DIR="$(dirname "${0}")"
>  LLVM_DIR="${THIS_DIR}/../../../third_party/llvm"
>
>

Expand Messages | Collapse Messages