Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 9835085: Revert 128696 - roll clang 151385:153254 due to mac sizes regression (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/scripts/update.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 128745)
+++ build/common.gypi (working copy)
@@ -2052,10 +2052,6 @@
# Invalid() in gmocks's gmock-internal-utils.h
# http://crbug.com/111806
'-Wno-null-dereference',
-
- # TODO(thakis): Investigate if it's worth cleaning up the code
- # and turning this on.
- '-Wno-null-conversion',
],
'cflags!': [
# Clang doesn't seem to know know this flag.
@@ -2475,10 +2471,6 @@
# Invalid() in gmock's gmock-internal-utils.h
# http://crbug.com/111806
'-Wno-null-dereference',
-
- # TODO(thakis): Investigate if it's worth cleaning up the code
- # and turning this on.
- '-Wno-null-conversion',
],
}],
['clang==1 and clang_use_chrome_plugins==1', {
« no previous file with comments | « no previous file | tools/clang/scripts/update.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698