Chromium Code Reviews
Help | Chromium Project | Sign in
(4)

Issue 9835055: Properly AdjustAmountOfExternalAllocatedMemory() in d8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by Jakob
Modified:
3 years ago
Reviewers:
Vyacheslav Egorov
CC:
v8-dev
Visibility:
Public.

Description

Properly AdjustAmountOfExternalAllocatedMemory() in d8 This is related to v8 issue 2022 but doesn't fix it as this patch only affects d8, while there is a related bug in the WebKit V8 bindings too. Committed: https://code.google.com/p/v8/source/detail?r=11144

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/d8.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Jakob
As discussed.
3 years ago (2012-03-23 15:51:03 UTC) #1
Vyacheslav Egorov
lgtm https://chromiumcodereview.appspot.com/9835055/diff/1/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/9835055/diff/1/src/d8.cc#newcode436 src/d8.cc:436: *reinterpret_cast<size_t*>(data) = length * element_size; you can store ...
3 years ago (2012-03-26 12:43:23 UTC) #2
Jakob
3 years ago (2012-03-26 14:08:03 UTC) #3
Thanks for the review. Landed.

https://chromiumcodereview.appspot.com/9835055/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/9835055/diff/1/src/d8.cc#newcode436
src/d8.cc:436: *reinterpret_cast<size_t*>(data) = length * element_size;
On 2012/03/26 12:43:23, Vyacheslav Egorov wrote:
> you can store total_size here.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted