Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 9834092: Content shell: Use only public API. (Closed)

Created:
8 years, 9 months ago by Avi (use Gerrit)
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Content shell: Use only public API. BUG=119869 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129010

Patch Set 1 #

Total comments: 3

Patch Set 2 : fixed DEPS #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -71 lines) Patch
M content/shell/DEPS View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/shell/shell.h View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M content/shell/shell.cc View 1 2 7 chunks +30 lines, -31 lines 0 comments Download
M content/shell/shell_browser_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_browser_main_parts.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/shell_gtk.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M content/shell/shell_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_render_view_host_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_win.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
jam: all but gtk erg: gtk
8 years, 9 months ago (2012-03-24 23:04:44 UTC) #1
jam
lgtm http://codereview.chromium.org/9834092/diff/1/content/shell/DEPS File content/shell/DEPS (right): http://codereview.chromium.org/9834092/diff/1/content/shell/DEPS#newcode6 content/shell/DEPS:6: "-content", nit: not needed, this is in its ...
8 years, 9 months ago (2012-03-24 23:11:29 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/9834092/diff/1/content/shell/DEPS File content/shell/DEPS (right): http://codereview.chromium.org/9834092/diff/1/content/shell/DEPS#newcode8 content/shell/DEPS:8: "+content/shell", Perhaps I misread the output of check_deps but ...
8 years, 9 months ago (2012-03-24 23:13:57 UTC) #3
Avi (use Gerrit)
You're right; fixed.
8 years, 9 months ago (2012-03-24 23:19:17 UTC) #4
Elliot Glaysher
lgtm
8 years, 9 months ago (2012-03-26 17:22:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9834092/5001
8 years, 9 months ago (2012-03-26 17:48:32 UTC) #6
commit-bot: I haz the power
Try job failure for 9834092-5001 on android for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&number=5556 Step "update" is always ...
8 years, 9 months ago (2012-03-26 17:52:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9834092/12003
8 years, 9 months ago (2012-03-26 17:58:57 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-26 21:22:57 UTC) #9
Try job failure for 9834092-12003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, net_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698