gdata: Fix issue with copying hosted documents out from Docs folder.

gdata: Fix issue with copying hosted documents out from Docs folder.

This CL changes GDataFileSystem to generate temporary document JSON
files in a sub-directory under the cache tmp directory, which can be
accessed by the file browser extension.

BUG=chromium-os:28384
TEST=Tested the following:
1. Run "unit_tests --gtest_filter='*GData*'"
2. Manually test copying and moving hosted documents from Docs folder
   to Downloads folder in file manager.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128808

[Ben Chan, 2012-03-24 22:55:34]

https://chromiumcodereview.appspot.com/9834091/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/9834091/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/gdata/gdata_file_system.cc:431: // JSON files.
Should we bail out here or return an error in
CreateDocumentJsonFileOnIOThreadPool?

[zel, 2012-03-24 23:03:10]

https://chromiumcodereview.appspot.com/9834091/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/9834091/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/gdata/gdata_file_system.cc:432:
CHECK(temp_document_dir_.CreateUniqueTempDir());
you can't create dir on UI thread - check CreateCacheDirectories() and do this
there

[Ben Chan, 2012-03-24 23:33:46]

PTAL

https://chromiumcodereview.appspot.com/9834091/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/9834091/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/gdata/gdata_file_system.cc:432:
CHECK(temp_document_dir_.CreateUniqueTempDir());
On 2012/03/24 23:03:10, zel wrote:
> you can't create dir on UI thread - check CreateCacheDirectories() and do this
> there

Done.

[zel, 2012-03-24 23:35:46]

lgtm

[satorux1, 2012-03-24 23:42:51]

http://codereview.chromium.org/9834091/diff/5001/chrome/browser/chromeos/gdat...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/9834091/diff/5001/chrome/browser/chromeos/gdat...
chrome/browser/chromeos/gdata/gdata_file_system.cc:451:
file_util::Delete(temp_document_dir_, true);
Oh you cannot do this here. 

BrowserThread::IO is for network IO. Cannot do file IO.

[zel, 2012-03-24 23:46:28]

lgtm

http://codereview.chromium.org/9834091/diff/5001/chrome/browser/chromeos/gdat...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/9834091/diff/5001/chrome/browser/chromeos/gdat...
chrome/browser/chromeos/gdata/gdata_file_system.cc:451:
file_util::Delete(temp_document_dir_, true);
On 2012/03/24 23:42:51, satorux1 wrote:
> Oh you cannot do this here. 
> 
> BrowserThread::IO is for network IO. Cannot do file IO.

we can just leave this directory in place, no harm here

[Ben Chan, 2012-03-25 00:22:13]

Changed the use /tmp/documents in cache for hosting the temp JSON file.  Since
the file browser extension already has read access to the cache dir, no need to
grant extra permissions

+kuan to review the changes

[kuan, 2012-03-25 00:35:02]

http://codereview.chromium.org/9834091/diff/2002/chrome/browser/chromeos/gdat...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/9834091/diff/2002/chrome/browser/chromeos/gdat...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1039:
GetGDataTempDocumentFolderPath(),
this part lgtm.

[commit-bot: I haz the power, 2012-03-25 00:36:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benchan@chromium.org/9834091/2002

[commit-bot: I haz the power, 2012-03-25 03:09:14]

Try job failure for 9834091-2002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-25 03:34:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benchan@chromium.org/9834091/5009

[commit-bot: I haz the power, 2012-03-25 06:10:11]

Try job failure for 9834091-5009 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-25 06:46:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benchan@chromium.org/9834091/5014

[commit-bot: I haz the power, 2012-03-25 08:03:14]

Change committed as 128808