Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: ui/base/models/combobox_model.h

Issue 9817007: ui/base/models: Add protected virtual destructor to ComboboxModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unittest Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/combobox/native_combobox_views_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/models/combobox_model.h
diff --git a/ui/base/models/combobox_model.h b/ui/base/models/combobox_model.h
index 57dd3c325c97d7896f0e0bf9692cb9b79389cece..4f3f781992e6a8067a9fb0d0343dfd324cd68848 100644
--- a/ui/base/models/combobox_model.h
+++ b/ui/base/models/combobox_model.h
@@ -10,16 +10,17 @@
namespace ui {
-// The interface for models backing a combobox.
+// A data model for a combo box.
class ComboboxModel {
public:
- virtual ~ComboboxModel() {}
-
- // Return the number of items in the combo box.
+ // Returns the number of items in the combo box.
virtual int GetItemCount() = 0;
- // Return the string that should be used to represent a given item.
+ // Returns the string at the specified index.
virtual string16 GetItemAt(int index) = 0;
+
+ protected:
+ virtual ~ComboboxModel() {}
};
} // namespace ui
« no previous file with comments | « no previous file | ui/views/controls/combobox/native_combobox_views_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698