Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: ui/views/controls/combobox/native_combobox_views_unittest.cc

Issue 9817007: ui/base/models: Add protected virtual destructor to ComboboxModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unittest Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/models/combobox_model.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/native_combobox_views_unittest.cc
diff --git a/ui/views/controls/combobox/native_combobox_views_unittest.cc b/ui/views/controls/combobox/native_combobox_views_unittest.cc
index caa1275968042cbba6822b94ea017ceafa269943..2474c4ad316d3d872e6e50bc3e8c807cc7e12b97 100644
--- a/ui/views/controls/combobox/native_combobox_views_unittest.cc
+++ b/ui/views/controls/combobox/native_combobox_views_unittest.cc
@@ -135,14 +135,14 @@ class NativeComboboxViewsTest : public ViewsTestBase {
// We need widget to populate wrapper class.
Widget* widget_;
- // combobox_ will be allocated InitCombobox() and then owned by widget_.
+ // |combobox_| will be allocated InitCombobox() and then owned by |widget_|.
TestCombobox* combobox_;
- // combobox_view_ is the pointer to the pure Views interface of combobox_.
+ // |combobox_view_| is the pointer to the pure Views interface of |combobox_|.
NativeComboboxViews* combobox_view_;
- // Combobox does not take ownership of model_, which needs to be scoped.
- scoped_ptr<ui::ComboboxModel> model_;
+ // Combobox does not take ownership of the model, hence it needs to be scoped.
+ scoped_ptr<TestComboboxModel> model_;
// For testing input method related behaviors.
MockInputMethod* input_method_;
« no previous file with comments | « ui/base/models/combobox_model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698