Remove "-mfloat-abi=hard" from host compiler cflags, which causes building chrome browser failure.

While building arm hardfp chrome browser, remove "-mfloat-abi=hard" from host compiler cflags, which causes building chrome browser failure.

BUG=https://code.google.com/p/chrome-os-partner/issues/detail?id=8539
TEST=manually build chrome browser use "hard"

Committed: https://code.google.com/p/v8/source/detail?r=11160

[Han, 2012-03-22 23:24:57]

Hi Rico, we are from chromeos-toolchain team and are trying to enable hardfp for
chromiumos, could you take a look at this CL, which blocks the build of
chromeos-chrome?

Thanks,
-Han

[ricow1, 2012-03-24 10:51:31]

Adding Sven and Jakob as reviewers (Jakob did our gyp files and Sven is doing a
bunch of arm stuff)

[Jakob Kummerow, 2012-03-24 12:27:10]

https://chromiumcodereview.appspot.com/9810036/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/9810036/diff/1/build/common.gypi#newco...
build/common.gypi:143: '-mfloat-abi=hard',
I'd say that instead of first defining -mfloat-abi=hard and then conditionally
filtering it again, it would be cleaner to define it conditionally in the first
place:

'target_conditions': [
  ['_toolset=="target"', {
    'cflags': ['-mfloat-abi=hard',],
  }],
],

I think it's fine that this approach ignores the host_arch, as the host toolset
is used only at compile time anyway and its compile flags do not affect the
resulting target binaries.

[Han, 2012-03-26 21:19:58]

On 2012/03/24 12:27:10, Jakob wrote:
> https://chromiumcodereview.appspot.com/9810036/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/9810036/diff/1/build/common.gypi#newco...
> build/common.gypi:143: '-mfloat-abi=hard',
> I'd say that instead of first defining -mfloat-abi=hard and then conditionally
> filtering it again, it would be cleaner to define it conditionally in the
first
> place:
> 
> 'target_conditions': [
>   ['_toolset=="target"', {
>     'cflags': ['-mfloat-abi=hard',],
>   }],
> ],
> 
> I think it's fine that this approach ignores the host_arch, as the host
toolset
> is used only at compile time anyway and its compile flags do not affect the
> resulting target binaries.

Hi Jakob, thanks!

Updated according to your comments. And tested locally.

Regards,
-Han

[Jakob Kummerow, 2012-03-27 11:24:09]

Thanks, LGTM. I'll land this for you.