Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Side by Side Diff: build/common.gypi

Issue 9810036: Remove "-mfloat-abi=hard" from host compiler cflags, which causes building chrome browser failure. (Closed) Base URL: http://git.chromium.org/external/v8.git@master
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 'defines': [ 133 'defines': [
134 'CAN_USE_VFP_INSTRUCTIONS', 134 'CAN_USE_VFP_INSTRUCTIONS',
135 ], 135 ],
136 }], 136 }],
137 [ 'v8_use_arm_eabi_hardfloat=="true"', { 137 [ 'v8_use_arm_eabi_hardfloat=="true"', {
138 'defines': [ 138 'defines': [
139 'USE_EABI_HARDFLOAT=1', 139 'USE_EABI_HARDFLOAT=1',
140 'CAN_USE_VFP_INSTRUCTIONS', 140 'CAN_USE_VFP_INSTRUCTIONS',
141 ], 141 ],
142 'cflags': [ 142 'cflags': [
143 '-mfloat-abi=hard', 143 '-mfloat-abi=hard',
Jakob Kummerow 2012/03/24 12:27:10 I'd say that instead of first defining -mfloat-abi
144 ], 144 ],
145 }, { 145 }, {
146 'defines': [ 146 'defines': [
147 'USE_EABI_HARDFLOAT=0', 147 'USE_EABI_HARDFLOAT=0',
148 ], 148 ],
149 }], 149 }],
150 # The ARM assembler assumes the host is 32 bits, 150 # The ARM assembler assumes the host is 32 bits,
151 # so force building 32-bit host tools. 151 # so force building 32-bit host tools.
152 ['host_arch=="x64" or OS=="android"', { 152 ['host_arch=="x64" or OS=="android"', {
153 'target_conditions': [ 153 'target_conditions': [
154 ['_toolset=="host"', { 154 ['_toolset=="host"', {
155 'cflags': ['-m32'], 155 'cflags': ['-m32'],
156 'ldflags': ['-m32'], 156 'ldflags': ['-m32'],
157 }], 157 }],
158 ], 158 ],
159 }], 159 }],
160 # Host compiler other than arm does not have "-mfloat-abi=hard"
161 # option, remove it from cflags.
162 ['host_arch!="arm"', {
163 'target_conditions': [
164 ['_toolset=="host"', {
165 'cflags!': ['-mfloat-abi=hard'],
166 }],
167 ],
168 }],
160 ], 169 ],
161 }], 170 }],
162 ['v8_target_arch=="ia32"', { 171 ['v8_target_arch=="ia32"', {
163 'defines': [ 172 'defines': [
164 'V8_TARGET_ARCH_IA32', 173 'V8_TARGET_ARCH_IA32',
165 ], 174 ],
166 }], 175 }],
167 ['v8_target_arch=="mips"', { 176 ['v8_target_arch=="mips"', {
168 'defines': [ 177 'defines': [
169 'V8_TARGET_ARCH_MIPS', 178 'V8_TARGET_ARCH_MIPS',
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 # some test cases can cause stack overflow. 392 # some test cases can cause stack overflow.
384 # 'StackReserveSize': '297152', 393 # 'StackReserveSize': '297152',
385 }, 394 },
386 }, 395 },
387 }], # OS=="win" 396 }], # OS=="win"
388 ], # conditions 397 ], # conditions
389 }, # Release 398 }, # Release
390 }, # configurations 399 }, # configurations
391 }, # target_defaults 400 }, # target_defaults
392 } 401 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698