Issue 9810020: bookmarks: "Open in New Tab" menu should open the bookmark in background.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9810020: bookmarks: "Open in New Tab" menu should open the bookmark in background. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

bookmarks: "Open in New Tab" menu should open the bookmark in background. BUG=112059 TEST=right click a bookmark, click in "Open in New Tab". A new tab should be created in the background. R=sky@chromium.org TBR=arv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128210

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -4 lines)			Patch
M	chrome/browser/bookmarks/bookmark_context_menu_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/bookmark_manager/js/main.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

sky

Doesn't this change 'open all', where as the bug report mentions 'open in new tab'?

8 years, 9 months ago (2012-03-21 22:30:39 UTC) #2

tfarina

On 2012/03/21 22:30:39, sky wrote: > Doesn't this change 'open all', where as the bug ...

8 years, 9 months ago (2012-03-21 23:14:09 UTC) #3

That would explain it. LGTM