Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/bookmarks/bookmark_context_menu_controller.cc

Issue 9810020: bookmarks: "Open in New Tab" menu should open the bookmark in background. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/resources/bookmark_manager/js/main.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_context_menu_controller.h" 5 #include "chrome/browser/bookmarks/bookmark_context_menu_controller.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/bookmarks/bookmark_editor.h" 9 #include "chrome/browser/bookmarks/bookmark_editor.h"
10 #include "chrome/browser/bookmarks/bookmark_model.h" 10 #include "chrome/browser/bookmarks/bookmark_model.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 void BookmarkContextMenuController::ExecuteCommand(int id) { 106 void BookmarkContextMenuController::ExecuteCommand(int id) {
107 if (delegate_) 107 if (delegate_)
108 delegate_->WillExecuteCommand(); 108 delegate_->WillExecuteCommand();
109 109
110 switch (id) { 110 switch (id) {
111 case IDC_BOOKMARK_BAR_OPEN_ALL: 111 case IDC_BOOKMARK_BAR_OPEN_ALL:
112 case IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO: 112 case IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO:
113 case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW: { 113 case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW: {
114 WindowOpenDisposition initial_disposition; 114 WindowOpenDisposition initial_disposition;
115 if (id == IDC_BOOKMARK_BAR_OPEN_ALL) { 115 if (id == IDC_BOOKMARK_BAR_OPEN_ALL) {
116 initial_disposition = NEW_FOREGROUND_TAB; 116 initial_disposition = NEW_BACKGROUND_TAB;
117 content::RecordAction( 117 content::RecordAction(
118 UserMetricsAction("BookmarkBar_ContextMenu_OpenAll")); 118 UserMetricsAction("BookmarkBar_ContextMenu_OpenAll"));
119 } else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) { 119 } else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) {
120 initial_disposition = NEW_WINDOW; 120 initial_disposition = NEW_WINDOW;
121 content::RecordAction( 121 content::RecordAction(
122 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow")); 122 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow"));
123 } else { 123 } else {
124 initial_disposition = OFF_THE_RECORD; 124 initial_disposition = OFF_THE_RECORD;
125 content::RecordAction( 125 content::RecordAction(
126 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito")); 126 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito"));
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 delegate_->CloseMenu(); 313 delegate_->CloseMenu();
314 } 314 }
315 315
316 bool BookmarkContextMenuController::HasURLs() const { 316 bool BookmarkContextMenuController::HasURLs() const {
317 for (size_t i = 0; i < selection_.size(); ++i) { 317 for (size_t i = 0; i < selection_.size(); ++i) {
318 if (bookmark_utils::NodeHasURLs(selection_[i])) 318 if (bookmark_utils::NodeHasURLs(selection_[i]))
319 return true; 319 return true;
320 } 320 }
321 return false; 321 return false;
322 } 322 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/bookmark_manager/js/main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698