Move TTS extension API to chrome/browser/speech/

Move TTS extension API to chrome/browser/speech/

Renames the files trivially, basically extension_tts -> tts_extension.
No code changes in this CL!

Also adds dmazzoni and dtseng to the OWNERS file of chrome/browser/speech.
Obviously we won't review changes related to the speech input api, if
someone pings one of us by accident we'll refer them to Satish.

BUG=104467
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128709

[Satish, 2012-03-22 19:40:51]

Could we move into chrome/browser/speech/extension_api ? We were thinking of
moving the speech reco extension api into that folder soon.

[dmazzoni, 2012-03-22 20:25:59]

On Thu, Mar 22, 2012 at 12:40 PM,  <satish@chromium.org> wrote:
> Could we move into chrome/browser/speech/extension_api ? We were thinking of
> moving the speech reco extension api into that folder soon.

No problem, done.

> http://codereview.chromium.org/9808024/

[Satish, 2012-03-22 20:33:41]

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/OWNERS
File chrome/browser/speech/OWNERS (right):

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/OWNERS...
chrome/browser/speech/OWNERS:3: dmazzoni@chromium.org
can we move this addition to an OWNERS file in the new extension_api directory

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/extens...
File chrome/browser/speech/extension_api/tts_engine_extension_api.h (right):

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/extens...
chrome/browser/speech/extension_api/tts_engine_extension_api.h:1: // Copyright
(c) 2011 The Chromium Authors. All rights reserved.
update copyright here and in other files

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/extens...
chrome/browser/speech/extension_api/tts_engine_extension_api.h:42: class
ExtensionTtsEngineSendTtsEventFunction : public SyncExtensionFunction {
since you've renamed the files do you plan to rename the classes to match as
well?

[dmazzoni, 2012-03-22 20:42:15]

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/OWNERS
File chrome/browser/speech/OWNERS (right):

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/OWNERS...
chrome/browser/speech/OWNERS:3: dmazzoni@chromium.org
On 2012/03/22 20:33:42, Satish wrote:
> can we move this addition to an OWNERS file in the new extension_api directory

Done.

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/extens...
File chrome/browser/speech/extension_api/tts_engine_extension_api.h (right):

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/extens...
chrome/browser/speech/extension_api/tts_engine_extension_api.h:1: // Copyright
(c) 2011 The Chromium Authors. All rights reserved.
On 2012/03/22 20:33:42, Satish wrote:
> update copyright here and in other files

Done.

http://codereview.chromium.org/9808024/diff/3005/chrome/browser/speech/extens...
chrome/browser/speech/extension_api/tts_engine_extension_api.h:42: class
ExtensionTtsEngineSendTtsEventFunction : public SyncExtensionFunction {
On 2012/03/22 20:33:42, Satish wrote:
> since you've renamed the files do you plan to rename the classes to match as
> well?

Yes, but OK if I save that for a follow-on changelist? There's other refactoring
and cleanup that would be nice now that it's in a better location.

[Satish, 2012-03-22 20:46:43]

lgtm

[dmazzoni, 2012-03-23 22:27:54]

+pkasting for OWNERS review of chrome/browser/ui

aa: would you like to lgtm for the record?

[Peter Kasting, 2012-03-24 00:59:46]

LGTM

[commit-bot: I haz the power, 2012-03-24 06:52:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/9808024/47

[commit-bot: I haz the power, 2012-03-24 06:52:49]

Presubmit check for 9808024-47 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    chrome/browser/speech/extension_api/tts_extension_api_win.cc:48
    chrome/browser/speech/extension_api/tts_extension_api_win.cc:69
    chrome/browser/speech/extension_api/tts_extension_api_win.cc:70
    chrome/browser/speech/extension_api/tts_extension_api_win.cc:90
    chrome/browser/speech/extension_api/tts_extension_api_win.cc:106

Presubmit checks took 2.8s to calculate.