Extensions: Switch to new permission message system, part I

extensions/common/permissions/permissions_data.h

Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index 9a24fbf05d28d6288902bf7d2eb0dd686d5962a4..03d727022c7aa5ffda1b1cc21e69ffd4a2ce5af6 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -71,7 +71,7 @@ class PermissionsData {
       const Extension* extension,
       const PermissionSet* permissions);
 
-  // Returns true if we should skip the permisisons warning for the extension
+  // Returns true if we should skip the permissons warning for the extension

[Yoyo Zhou, 2015/03/11 01:33:23]

nit: permissions

[Marc Treib, 2015/03/11 13:08:52]

Done.

   // with the given |extension_id|.
   static bool ShouldSkipPermissionWarnings(const std::string& extension_id);
 
@@ -133,18 +133,21 @@ class PermissionsData {
 
   // Returns the full list of permission messages that should display at
   // install time.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  PermissionMessages GetPermissionMessages() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  PermissionMessages GetLegacyPermissionMessages() const;

[Yoyo Zhou, 2015/03/11 01:33:23]

Here's my thinking about flags. Ideally, we have some APIs like
GetPermissionMessages that we can hide the implementation change behind. I'm not
sure if works out that cleanly, but it would be best if GetPermissionMessages
and friends check the flag and, if it is set, use the new system.

If that doesn't work, I'm okay with your proposal to create a
CoalescedPermissionMessages legacy-style if the flag is set to 'legacy'. That
does mean that this change is not a no-op without the flag, though, since we
have switched to using CoalescedPermissionMessages and potentially introduced
bugs where we did so, etc. I think our test coverage is good enough to take that
risk.

[Marc Treib, 2015/03/11 13:08:52]

Alright. I'll do that and ping you again.

 
   // Returns the full list of permission messages that should display at install
   // time as strings.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  std::vector<base::string16> GetPermissionMessageStrings() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  std::vector<base::string16> GetLegacyPermissionMessageStrings() const;
 
   // Returns the full list of permission details for messages that should
   // display at install time as strings.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  std::vector<base::string16> GetPermissionMessageDetailsStrings() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  std::vector<base::string16> GetLegacyPermissionMessageDetailsStrings() const;
 
   // Returns the full list of permission details for messages that should
   // display at install time, in a nested format ready for display.