Extensions: Switch to new permission message system, part I

extensions/common/permissions/permissions_data.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_
 #define EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 53 matching lines @@
   static bool CanExecuteScriptEverywhere(const Extension* extension);
 
   // Returns true if the --scripts-require-action flag would possibly affect
   // the given |extension| and |permissions|. We pass in the |permissions|
   // explicitly, as we may need to check with permissions other than the ones
   // that are currently on the extension's PermissionsData.
   static bool ScriptsMayRequireActionForExtension(
       const Extension* extension,
       const PermissionSet* permissions);
 
-  // Returns true if we should skip the permisisons warning for the extension
+  // Returns true if we should skip the permissons warning for the extension

[Yoyo Zhou, 2015/03/11 01:33:23]

nit: permissions

[Marc Treib, 2015/03/11 13:08:52]

Done.

   // with the given |extension_id|.
   static bool ShouldSkipPermissionWarnings(const std::string& extension_id);
 
   // Returns true if the given |url| is restricted for the given |extension|,
   // as is commonly the case for chrome:// urls.
   // NOTE: You probably want to use CanAccessPage().
   static bool IsRestrictedUrl(const GURL& document_url,
                               const GURL& top_frame_url,
                               const Extension* extension,
                               std::string* error);
@@ skipping 41 matching lines @@
 
   // Whether the extension has effective access to all hosts. This is true if
   // there is a content script that matches all hosts, if there is a host
   // permission grants access to all hosts (like <all_urls>) or an api
   // permission that effectively grants access to all hosts (e.g. proxy,
   // network, etc.)
   bool HasEffectiveAccessToAllHosts() const;
 
   // Returns the full list of permission messages that should display at
   // install time.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  PermissionMessages GetPermissionMessages() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  PermissionMessages GetLegacyPermissionMessages() const;

[Yoyo Zhou, 2015/03/11 01:33:23]

Here's my thinking about flags. Ideally, we have some APIs like
GetPermissionMessages that we can hide the implementation change behind. I'm not
sure if works out that cleanly, but it would be best if GetPermissionMessages
and friends check the flag and, if it is set, use the new system.

If that doesn't work, I'm okay with your proposal to create a
CoalescedPermissionMessages legacy-style if the flag is set to 'legacy'. That
does mean that this change is not a no-op without the flag, though, since we
have switched to using CoalescedPermissionMessages and potentially introduced
bugs where we did so, etc. I think our test coverage is good enough to take that
risk.

[Marc Treib, 2015/03/11 13:08:52]

Alright. I'll do that and ping you again.

 
   // Returns the full list of permission messages that should display at install
   // time as strings.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  std::vector<base::string16> GetPermissionMessageStrings() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  std::vector<base::string16> GetLegacyPermissionMessageStrings() const;
 
   // Returns the full list of permission details for messages that should
   // display at install time as strings.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  std::vector<base::string16> GetPermissionMessageDetailsStrings() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  std::vector<base::string16> GetLegacyPermissionMessageDetailsStrings() const;
 
   // Returns the full list of permission details for messages that should
   // display at install time, in a nested format ready for display.
   CoalescedPermissionMessages GetCoalescedPermissionMessages() const;
 
   // Returns true if the extension has requested all-hosts permissions (or
   // something close to it), but has had it withheld.
   bool HasWithheldImpliedAllHosts() const;
 
   // Returns true if the |extension| has permission to access and interact with
@@ skipping 119 matching lines @@
   mutable scoped_refptr<const PermissionSet> withheld_permissions_unsafe_;
 
   mutable TabPermissionsMap tab_specific_permissions_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionsData);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_