Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 9796012: Revert 127833 - Re-land alexbost's experimental offscreenTabs API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_module.h
===================================================================
--- chrome/browser/extensions/extension_tabs_module.h (revision 127860)
+++ chrome/browser/extensions/extension_tabs_module.h (working copy)
@@ -17,17 +17,13 @@
#include "googleurl/src/gurl.h"
class BackingStore;
-class Extension;
-class GURL;
class SkBitmap;
-class TabContentsWrapper;
namespace base {
class DictionaryValue;
} // namespace base
namespace content {
class WebContents;
} // namespace content
-
// Windows
class GetWindowFunction : public SyncExtensionFunction {
virtual ~GetWindowFunction() {}
@@ -114,23 +110,17 @@
public content::WebContentsObserver {
public:
UpdateTabFunction();
-
- protected:
- virtual ~UpdateTabFunction() {}
- virtual bool UpdateURLIfPresent(base::DictionaryValue* update_props,
- bool* is_async);
- virtual void PopulateResult();
-
- content::WebContents* web_contents_;
-
private:
+ virtual ~UpdateTabFunction() {}
virtual bool RunImpl() OVERRIDE;
virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
void OnExecuteCodeFinished(int request_id,
bool success,
const std::string& error);
+ void PopulateResult();
+ content::WebContents* web_contents_;
DECLARE_EXTENSION_FUNCTION_NAME("tabs.update")
};
class MoveTabsFunction : public SyncExtensionFunction {
@@ -163,7 +153,7 @@
};
class CaptureVisibleTabFunction : public AsyncExtensionFunction,
public content::NotificationObserver {
- protected:
+ private:
enum ImageFormat {
FORMAT_JPEG,
FORMAT_PNG
@@ -174,11 +164,10 @@
virtual ~CaptureVisibleTabFunction() {}
virtual bool RunImpl() OVERRIDE;
- virtual bool GetTabToCapture(content::WebContents** web_contents,
- TabContentsWrapper** wrapper);
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ bool CaptureSnapshotFromBackingStore(BackingStore* backing_store);
void SendResultFromBitmap(const SkBitmap& screen_capture);
content::NotificationRegistrar registrar_;
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698