Issue 9796012: Revert 127833 - Re-land alexbost's experimental offscreenTabs API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9796012: Revert 127833 - Re-land alexbost's experimental offscreenTabs API. (Closed)

Created:
8 years, 9 months ago by dgrogan

Modified:
8 years, 9 months ago

Reviewers:
jstritar

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 127833 - Re-land alexbost's experimental offscreenTabs API. Original code review: http://codereview.chromium.org/7720002/ A followup code review: http://chromiumcodereview.appspot.com/9150052/ This includes some refactoring to simplify and reduce the code size: - sharing more code between tabs and offscreenTabs - splitting up and fixing the browser tests - forbidding use of the API from a background page BUG=110833 TEST=OffscreenTabsApiTest.* Review URL: https://chromiumcodereview.appspot.com/9234042 TBR=jstritar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127863

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -3760 lines)			Patch
D	chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h	View	1 chunk	+0 lines, -132 lines	0 comments	Download
D	chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc	View	1 chunk	+0 lines, -833 lines	0 comments	Download
D	chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_apitest.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
D	chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_constants.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_constants.cc	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	chrome/browser/extensions/extension_event_names.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_event_names.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_util.h	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_util.cc	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.h	View	4 chunks	+5 lines, -16 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View	13 chunks	+97 lines, -91 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/common_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/common/extensions/api/experimental.offscreenTabs.json	View	1 chunk	+0 lines, -353 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/tabs.json	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/common/extensions/docs/experimental.offscreenTabs.html	View	1 chunk	+0 lines, -1655 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1 chunk	+0 lines, -9 lines	0 comments	Download
MM	chrome/renderer/extensions/extension_dispatcher.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
MM	chrome/renderer/renderer_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js	View	1 chunk	+0 lines, -63 lines	0 comments	Download
MM	chrome/test/data/extensions/api_test/get_views/test.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/a.html	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/b.html	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/c.html	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/crud.html	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/crud.js	View	1 chunk	+0 lines, -66 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/display.html	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/display.js	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/keyboard_events.html	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/keyboard_events.js	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/manifest.json	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/mouse_events.html	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/mouse_events.js	View	1 chunk	+0 lines, -95 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/offscreen_tabs/tab_util.js	View	1 chunk	+0 lines, -53 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages