Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 9791078: Stop sending/saving cookies for translate server requests. (Closed)

Created:
8 years, 9 months ago by MAD
Modified:
8 years, 9 months ago
Reviewers:
battre
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Stop sending/saving cookies for translate server requests. Add hl=<UI Language> query param instead. BUG=118960 TEST=browsertest --gtest_filter=TranslateManagerTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129577

Patch Set 1 #

Patch Set 2 : c_str #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/browser/translate/translate_manager.cc View 1 5 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
MAD
Is this OK with you? Thanks! BYE MAD
8 years, 9 months ago (2012-03-28 19:26:38 UTC) #1
battre
LGTM Perfect, thanks a lot.
8 years, 9 months ago (2012-03-28 19:30:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/9791078/1
8 years, 9 months ago (2012-03-28 19:32:12 UTC) #3
commit-bot: I haz the power
Try job failure for 9791078-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-28 19:55:46 UTC) #4
MAD
Oops... forgot a .c_str()... I'll update soon...ish... :-) BYE MAD Le 28 mars 2012 15:55, ...
8 years, 9 months ago (2012-03-28 20:14:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/9791078/7001
8 years, 9 months ago (2012-03-29 02:58:27 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-29 04:41:12 UTC) #7
Change committed as 129577

Powered by Google App Engine
This is Rietveld 408576698