src/v8.cc - Issue 9791016: Valgrind cleanliness, part 1: Delete current isolate on exit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8.cc

Issue 9791016: Valgrind cleanliness, part 1: Delete current isolate on exit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8.cc

diff --git a/src/v8.cc b/src/v8.cc

index 506f3f66068bb2809d06fd4297d231fe602b20eb..fdc8a90e41e61c869bfcf015b14487252fac8505 100644

--- a/src/v8.cc

+++ b/src/v8.cc

@@ -103,7 +103,9 @@ void V8::TearDown() {

ASSERT(isolate->IsDefaultIsolate());

if (!has_been_set_up_ || has_been_disposed_) return;

isolate->TearDown();

+ delete isolate;

is_running_ = false;

has_been_disposed_ = true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »