Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/v8.cc

Issue 9791016: Valgrind cleanliness, part 1: Delete current isolate on exit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 is_running_ = false; 96 is_running_ = false;
97 has_fatal_error_ = true; 97 has_fatal_error_ = true;
98 } 98 }
99 99
100 100
101 void V8::TearDown() { 101 void V8::TearDown() {
102 Isolate* isolate = Isolate::Current(); 102 Isolate* isolate = Isolate::Current();
103 ASSERT(isolate->IsDefaultIsolate()); 103 ASSERT(isolate->IsDefaultIsolate());
104 104
105 if (!has_been_set_up_ || has_been_disposed_) return; 105 if (!has_been_set_up_ || has_been_disposed_) return;
106
106 isolate->TearDown(); 107 isolate->TearDown();
108 delete isolate;
107 109
108 is_running_ = false; 110 is_running_ = false;
109 has_been_disposed_ = true; 111 has_been_disposed_ = true;
110 112
111 delete call_completed_callbacks_; 113 delete call_completed_callbacks_;
112 call_completed_callbacks_ = NULL; 114 call_completed_callbacks_ = NULL;
113 } 115 }
114 116
115 117
116 static void seed_random(uint32_t* state) { 118 static void seed_random(uint32_t* state) {
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 } 267 }
266 268
267 LOperand::SetUpCaches(); 269 LOperand::SetUpCaches();
268 } 270 }
269 271
270 void V8::InitializeOncePerProcess() { 272 void V8::InitializeOncePerProcess() {
271 CallOnce(&init_once, &InitializeOncePerProcessImpl); 273 CallOnce(&init_once, &InitializeOncePerProcessImpl);
272 } 274 }
273 275
274 } } // namespace v8::internal 276 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698