Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 9791016: Valgrind cleanliness, part 1: Delete current isolate on exit. (Closed)

Created:
8 years, 9 months ago by Sven Panne
Modified:
8 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Valgrind cleanliness, part 1: Delete current isolate on exit. Currently we leak 140kB from 80 allocation sites when we evaluate a simple "print(1+2)" in d8 and exit. This might not be a real problem in Chrome because most of the time the whole process containing v8 vanishes, but it can hide real leaks in a sea of false positives. Therefore, this CL and a few subsequent ones clean this up a bit. This simple CL alone fixes 45 leaks, leaving only 35 with a net loss of 2192 bytes (on ia32). Committed: https://code.google.com/p/v8/source/detail?r=11146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/v8.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 9 months ago (2012-03-27 07:02:25 UTC) #1
danno
8 years, 9 months ago (2012-03-27 07:28:40 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698