Issue 9784002: Support non-speculative type propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9784002: Support non-speculative type propagation. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, kasperl, karlklose, ahe, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support non-speculative type propagation.

Patch Set 1 : #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -33 lines)			Patch
M	frog/leg/ssa/nodes.dart	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	frog/leg/ssa/optimize.dart	View	5 chunks	+6 lines, -2 lines	0 comments	Download
M	frog/leg/ssa/types.dart	View	3 chunks	+30 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9784002/diff/2002/frog/leg/ssa/types.dart File frog/leg/ssa/types.dart (right): https://chromiumcodereview.appspot.com/9784002/diff/2002/frog/leg/ssa/types.dart#newcode13 frog/leg/ssa/types.dart:13: SsaTypePropagator(Compiler this.compiler, bool this.speculative) I prefer not to ...

8 years, 9 months ago (2012-03-27 22:38:32 UTC) #2

ngeoffray

8 years, 9 months ago (2012-03-28 07:23:21 UTC) #3

Thank you Florian, submitted here:
https://chromiumcodereview.appspot.com/9874014

https://chromiumcodereview.appspot.com/9784002/diff/2002/frog/leg/ssa/types.dart
File frog/leg/ssa/types.dart (right):

https://chromiumcodereview.appspot.com/9784002/diff/2002/frog/leg/ssa/types.d...
frog/leg/ssa/types.dart:13: SsaTypePropagator(Compiler this.compiler, bool
this.speculative)
On 2012/03/27 22:38:33, floitsch wrote:
> I prefer not to type 'this.X' parameters, but your call.

I will keep it with the types since that's what was there before. My preference
would be to type it, but what would be best is consistency in the dart2js code
base. We can do a cleanup later.

Expand Messages | Collapse Messages